Fix ChannelProcessingFilter to skip decision if response already committed
#17668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itted In this commit, we quickly fix a bug in ChannelProcessingFilter#doFilter where if filterInvocation.getResponse().isCommitted() is checked before decide, it will not pass further into the filter, which is an error. Perhaps in the future it would be better to extend the ChannelDecisionManager interface directly, but it is deprecated and this would be difficult and beyond the scope of this commit. Closes: spring-projectsgh-6721 Signed-off-by: Andrey Litvitski <[email protected]>
|
I marked this commit as closing the issue, as I believe it fully resolves it. gh-6721 also mentioned that it might be worth changing the structure of the |
spring-projects-issues
added
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we quickly fix a bug in ChannelProcessingFilter#doFilter where if filterInvocation.getResponse().isCommitted() is checked before decide, it will not pass further into the filter, which is an error. Perhaps in the future it would be better to extend the ChannelDecisionManager interface directly, but it is deprecated and this would be difficult and beyond the scope of this commit.
Closes: gh-6721