[이혁진] 자동차 경주 게임 step2 코드리뷰 부탁드립니다 #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huhsay
reviewed
Oct 7, 2018
| this.name = name; | ||
| } | ||
|
|
||
| public int getDistance() { |
huhsay
reviewed
Oct 7, 2018
|
|
||
| public void moveCars() { | ||
| for (Car car : cars) { | ||
| moveSelectedCar(car, RandomValueGenerator.generate(BOUNDARY)); |
There was a problem hiding this comment.
랜덤값을 moveSelectedCar() 메소드 안에서 구현해도 될 것 같은데, 매개변수로 넣어준 이유는 테스트를 쉽게하기 위해서 인가요?
There was a problem hiding this comment.
네 moveSelectedCar를 테스트하기 위해서 했습니다!
esp2ar0
reviewed
Oct 8, 2018
|
|
||
| private String name; | ||
| private int distance; | ||
|
|
There was a problem hiding this comment.
domain에서 가지고 있는 정보를 여기서도 가지고 있어야 하나요?
There was a problem hiding this comment.
domain이 get set을 최대한 하면 안되게 DTO를 사용했습니다. DTO는 Data Transfer Object로, 해당 도메인에서 필요한 데이터를 DTO로 담아서 마치 모델의 분신처럼 다른 레이어들과 데이터 주고 받기를 가능하게하는 역할을 합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.