Open
Conversation
pouyakary
changed the title
Member
|
It looks nice :-) Would you remove those ".DS_Store" files from your commit? |
Author
|
@marceltaeumel thanks! And my goodness, sorry! I'll do it. However, I think it is a bit late for this icon. Apple is about to roll out the new macOS and it will require glass icons. I'll be contributing them if you're okay with it. |
Author
|
@marceltaeumel sorry for the .DS_Store. What ever I do, these always end up in the commits! |
Member
|
Can you scope these icons to the appropriate macOS version? Meaning, can all these icons be in the same bundle and show up differently on different macOS versions? |
Author
|
@marceltaeumel I have to check about that, I'm not sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squeak's icon for macOS no longer feels at home:
And so I decided to try to make it a bit at home, this is my try:
I hope that you like it too!