Migrate CI to GitHub Actions #5
Conversation
LinqLover
commented
Sep 3, 2021
•
LinqLover
commented
GitHub Actions does not support this at the moment, and it is unlikely that this will change in near future: actions/runner#1181 (comment)
| server_address: ${{ secrets.SMTP_SERVER }} | ||
| server_port: ${{ secrets.SMTP_PORT }} | ||
| username: ${{ secrets.SMTP_USERNAME }} | ||
| password: ${{ secrets.SMTP_PASSWORD }} | ||
| subject: GitHub Actions failed for ${{ github.repository }} | ||
| body: Build job of ${{ github.repository }} failed! See https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }} for more information. | ||
| to: ${{ secrets.MAIL_RECEIVER }} |
There was a problem hiding this comment.
If we do want this, someone who has admin access to this repository will need to enter these secrets. The workflow definition is copied pretty much 1:1 from another repository, so I don't expect hard-to-debug failures. I have already some working credentials available, please contact me privately and I'll send them to you. :D
There was a problem hiding this comment.
To which addresses would you like to send this? I guess most of the folks on squeak-dev are not interested in FileSystem. And neither is Pharo in this different version of the library.
There was a problem hiding this comment.
My first guess would have been squeak-dev since this repository is part of @squeak-smalltalk. Alternatively, I can also add me and you and some other interested people ...
There was a problem hiding this comment.
The ston, tonel, and filesystem repositories are a bit odd in this organization. They are effectively not as supported as, say, the Trunk of Squeak is. I do not believe that either of the three would be undisputedly considered to be part of Squeak, as opposed to what is in Trunk.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| 'srcDirectory' : 'src' | |||
There was a problem hiding this comment.
What does this file belong to and why is it introduced now?
There was a problem hiding this comment.
The commit message could have elaborated on the purpose of this.
There was a problem hiding this comment.
Sorry for confusion. This file explains the default directory of the package directory to the newest Metacello version so you do not need to specify the path manually in the load script.
|
@LinqLover I have merged this without the notify workflow for now, so it does not get blocked by not having a community email account any longer. |
|
...and created #10 to preserve the workflow for the future when we have solved the problem with the account. |
|
Ah, thank you, very nice! I will try to bring up this topic at HPI again during the next weeks. :-) |
