-
Notifications
You must be signed in to change notification settings - Fork 164
[RORDEV-1410] Data stream audit sink setup improvements #1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RORDEV-1410] Data stream audit sink setup improvements #1089
Conversation
I added changes for the es816x module. I will port to other modules when the solution is accepted |
core/src/main/scala/tech/beshu/ror/accesscontrol/audit/sink/AuditDataStreamCreator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/audit/sink/AuditDataStreamCreator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/audit/sink/EsDataStreamBasedAuditSink.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/tech/beshu/ror/unit/es/DataStreamServiceTest.scala
Outdated
Show resolved
Hide resolved
es816x/src/main/scala/tech/beshu/ror/es/services/EsDataStreamService.scala
Outdated
Show resolved
Hide resolved
es816x/src/main/scala/tech/beshu/ror/es/services/EsDataStreamService.scala
Show resolved
Hide resolved
es816x/src/main/scala/tech/beshu/ror/es/services/RestClientDataStreamService.scala
Show resolved
Hide resolved
es816x/src/main/scala/tech/beshu/ror/es/services/RestClientDataStreamService.scala
Outdated
Show resolved
Hide resolved
179d97a
to
a3851c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just minor comments.
let's port the changes to other ES modules.
BTW, it looks great!
core/src/main/scala/tech/beshu/ror/accesscontrol/audit/AuditingTool.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/audit/sink/AuditDataStreamCreator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/audit/sink/EsDataStreamBasedAuditSink.scala
Outdated
Show resolved
Hide resolved
es816x/src/main/scala/tech/beshu/ror/es/services/RestClientDataStreamService.scala
Outdated
Show resolved
Hide resolved
a3851c4
to
bbc6bc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
core/src/main/scala/tech/beshu/ror/accesscontrol/audit/sink/EsDataStreamBasedAuditSink.scala
Show resolved
Hide resolved
5e58c88
into
sscarduzio:epic/RORDEV-1263
No description provided.