Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various stability improvements & Cleanup #14

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

johannesduesing
Copy link
Member

@johannesduesing johannesduesing commented Nov 27, 2024

This PR essentially implements the improvements we found when optimizing our artifact during the evaluation. This includes:

  • Closing all Input Streams / URL connections that we open
  • Remove main method (and corresponding plugin in pom) - only for the evaluation we need an executable JAR
  • Improve relevant error logging, remove logging of FileNotFoundExceptions as they do not constitute an error
  • Use AtomicInteger where relevant to improve multithreaded behavior
  • Enforce HTTP timeouts
  • Recover from connection interruptions in iterator
  • Some minor code warnings cleaned up

…aks. Reduce unncessary exception logging, improve relevant exception handling
@johannesduesing johannesduesing added the enhancement New feature or request label Nov 27, 2024
@johannesduesing johannesduesing self-assigned this Nov 27, 2024
@johannesduesing johannesduesing merged commit c4c1929 into main Dec 2, 2024
1 check passed
@johannesduesing johannesduesing deleted the feature/stability-improvements branch December 2, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant