Proper mocking for tests of version range resolution #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of tests failing when new releases of certain libraries are published to Maven Central. Instead of using actual real-world data to conduct the test case for parsing version ranges, we now use fixed test data from the
PomInputs.jsonfile. While at it, i introduced theIReleaseListProviderinterface that encapsulates the retrieval of version lists, so it can be properly mocked during testing.I made sure i removed all invocations of
DefaultMavenReleaseListProviderduring testing, so we should at no point be dependent on live release data anymore - i dumped the real world release list "as of now", added them to the JSON test data files and used them as a ground truth for future testing.