-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor packaging #9
base: master
Are you sure you want to change the base?
Conversation
First of all, let me tell you I appreciate your efforts. Can we process step by step with a talk about priority first ? |
I'm puzzled by the issue with std::size_t, during last build for Linux I didn't notice anything although I used gcc12 |
Maybe we should consider adding in gbs/gbslib.h inside gbs namespace |
This seems reasonnable to me, since |
moreover some types are already defined here, so moving them into a specific place could be a good idea |
outchy, maybe I missed something then, a C header or something let me have a look
Sounds good in
let's do that!
Totally, sorry for this huge PR. When it comes to package refactoring there are a LOT of changes and it's quite impossible to review. Let's schedule a chat when possible! |
just including |
add a dedicated package structore for gbs(-core) and extensions create a gbs::core target for main lib create extension targets for extensions libs refactor CMakeLists.txt files for reflect dependencies add missing headers for size_t refactor Python bindings to install in Python sources
add missing forward decl of make_surface
742972a
to
457b9fd
Compare
I just forced pushed to:
Most changes are about |
add cmake configs for mesh, io, occt and render extensions
Now that you mention it, that is indeed what I usually do. |
Description
Refactor packaging:
gbs::core
target for main lib,gbs::<ext>
for extensions<prefix>/include/gbs
<prefix>/include/gbs
<prefix>/include/gbs/<ext>
(e.g.<prefix>/include/gbs/mesh
)include_directories
CMakeLists.txt
files for reflect dependencies (includes and linked libs)link_directories
<cstddef>
ingbslib.h
Note: this is a massive PR I would be happy to discuss
Note: there is no change in project implementation