Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catching NICK changes of users. #1

Closed
wants to merge 1 commit into from
Closed

Catching NICK changes of users. #1

wants to merge 1 commit into from

Conversation

drobati
Copy link

@drobati drobati commented Apr 13, 2015

desert-planet/hayt#141

Exposed that NICK changes aren't tracked and a user can vote twice.

Here we can hopefully track who is who and stop them from doing this maliciously with multiple nicks. #
@sshirokov
Copy link
Owner

Why did you open this against my fork?

@drobati
Copy link
Author

drobati commented Apr 14, 2015

A) We may not need this.
B) If you accept this then we could merge it to upstream later if it works for us?

I still need to figure out of the User id changes with nick changes. I think it does?

@sshirokov
Copy link
Owner

If you accept this then we could merge it to upstream later if it works for us?

I'm not going to accept anything to this repo. This is a fork for my work, not a central collaboration point.

Hell, it's super-out of date with the upstream anyway. You should definitely work from upstream instead of here.

@sshirokov sshirokov closed this Apr 14, 2015
@drobati
Copy link
Author

drobati commented Apr 14, 2015

Fair enough but Hayt uses this repo. 👍

@sshirokov
Copy link
Owner

Fair enough but Hayt uses this repo.

Because I'm lazy and haven't tested the upstream adapter after I wrote the PR 😿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants