Change schema to enforce error #738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrot
force-pushed
the
mysql-int-unsigned
branch
2 times, most recently
from
9f68d45 to
c9af85e
Compare
danrot
force-pushed
the
mysql-int-unsigned
branch
3 times, most recently
from
ff4ff99 to
ee506b5
Compare
danrot
force-pushed
the
mysql-int-unsigned
branch
from
ee506b5 to
f8b7b8e
Compare
staabm
reviewed
Jan 29, 2025
| @@ -30,7 +30,7 @@ ALTER TABLE `ak` | |||
|
|
|||
|
|
|||
| CREATE TABLE `typemix` ( | |||
| `pid` int NOT NULL, | |||
| `pid` int unsigned NOT NULL AUTO_INCREMENT, | |||
There was a problem hiding this comment.
I would prefer adding a new column at the end of this table instead of changing a existing column.
Additionally we need the same schema change in the pgsql schema file
There was a problem hiding this comment.
I am still trying to reproduce my issue #737... At first I thought it was somehow related to the column being the primary key, for which reason I added it here. And even though there seems to be some inconsistencies here since it is already breaking some tests, it's not failing in the way I supposed it to 🙈 I think I have to continue to try reproducing this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.