Skip to content

Fix benchmarks to build w/ pyproject.toml #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2023
Merged

Fix benchmarks to build w/ pyproject.toml #1122

merged 1 commit into from
May 15, 2023

Conversation

gadomski
Copy link
Member

Related issues:

Description:

asv expects setup.py so we need to customize the build commands. We also were surprised by CI not catching this problem, so updates CI to actual do builds.

No CHANGELOG entry needed IMO.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski added this to the 1.8 milestone May 12, 2023
@gadomski gadomski requested a review from ircwaves May 12, 2023 20:08
@gadomski gadomski self-assigned this May 12, 2023
Copy link
Member

@ircwaves ircwaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ ⚡ :shipit:

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (684b317) 90.33% compared to head (da9c0ed) 90.33%.

❗ Current head da9c0ed differs from pull request most recent head 91871a8. Consider uploading reports for the commit 91871a8 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1122   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files          48       48           
  Lines        6343     6343           
  Branches      944      944           
=======================================
  Hits         5730     5730           
  Misses        431      431           
  Partials      182      182           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski added this pull request to the merge queue May 15, 2023
Merged via the queue into main with commit e5efc44 May 15, 2023
@gadomski gadomski deleted the fix-bench branch May 15, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bench to work with pyproject.toml
3 participants