Skip to content

Fix recursion error when eo band name is missing#1406

Merged
gadomski merged 2 commits intomainfrom
issues/1402-recursion-error
Sep 26, 2024
Merged

Fix recursion error when eo band name is missing#1406
gadomski merged 2 commits intomainfrom
issues/1402-recursion-error

Conversation

@gadomski
Copy link
Copy Markdown
Member

@gadomski gadomski commented Sep 22, 2024

Related Issue(s):

Description:

Fixed simply by using get on the properties dict instead of the accessor.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski self-assigned this Sep 22, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.20%. Comparing base (5f53e6e) to head (9baf1be).
Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1406   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files          52       52           
  Lines        7239     7239           
  Branches     1019     1019           
=======================================
  Hits         6602     6602           
  Misses        457      457           
  Partials      180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski added this to the v1.11 milestone Sep 23, 2024
Copy link
Copy Markdown
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏

@gadomski gadomski added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 87e1a24 Sep 26, 2024
@gadomski gadomski deleted the issues/1402-recursion-error branch September 26, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling bands property on a pystac.extensions.eo.EOExtension can result in RecursionError

2 participants