get_root_link/get_child_links/get_item_links: Ensure correct media types#1497
Merged
gadomski merged 4 commits intostac-utils:mainfrom Jan 23, 2025
Merged
get_root_link/get_child_links/get_item_links: Ensure correct media types#1497gadomski merged 4 commits intostac-utils:mainfrom
gadomski merged 4 commits intostac-utils:mainfrom
Conversation
* Allow media_type on get_links and get_single_link to an iterable * Use `application/json", "application/geo+json" or None as the media_type for `get_root_link`, `get_child_links` and `get_item_links`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1497 +/- ##
=======================================
Coverage 91.46% 91.47%
=======================================
Files 54 54
Lines 7511 7518 +7
Branches 907 909 +2
=======================================
+ Hits 6870 6877 +7
Misses 457 457
Partials 184 184 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gadomski
requested changes
Jan 21, 2025
Member
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
Needs CHANGELOG as well as one DRY option.
gadomski
approved these changes
Jan 23, 2025
kmodali
pushed a commit
to kmodali/pystac
that referenced
this pull request
Oct 16, 2025
…pes (stac-utils#1497) * `get_root|child|item_links` should be json-like * Allow media_type on get_links and get_single_link to an iterable * Use `application/json", "application/geo+json" or None as the media_type for `get_root_link`, `get_child_links` and `get_item_links` * Dry up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
application/json", "application/geo+json" or None as the media_type forget_root_link,get_child_linksandget_item_links`PR Checklist:
scripts/test)