add cf extension #1592
add cf extension #1592
Conversation
|
FYI @fmigneault |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1592 +/- ##
==========================================
- Coverage 92.32% 91.29% -1.04%
==========================================
Files 55 56 +1
Lines 8381 8476 +95
Branches 966 973 +7
==========================================
Hits 7738 7738
- Misses 457 552 +95
Partials 186 186 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @gadomski |
Nope, this is in my queue to review, I just haven't gotten to it yet. |
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
Missing a few things:
- Tests
- Needs to implement an instance of
ExtensionHooks
There might be more, but adding those things will be a good next step.
| self.properties = collection.extra_fields | ||
|
|
||
| def __repr__(self) -> str: | ||
| return f"<CollectionCFExtension Item id={self.collection.id}>" |
There was a problem hiding this comment.
| return f"<CollectionCFExtension Item id={self.collection.id}>" | |
| return f"<CollectionCFExtension Item id={self.item.id}>" |
3 participants
Description: Add support for the CF Extension
PR Checklist:
pre-commit run --all-files)pytest)