Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more configuration options for Elasticsearch/OpenSearch #349

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

StijnCaerts
Copy link
Collaborator

@StijnCaerts StijnCaerts commented Apr 1, 2025

Related Issue(s):

Description:
Allow to configure multiple Elasticsearch/OpenSearch hosts (comma-separated) and enable http_compress by default.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@StijnCaerts StijnCaerts linked an issue Apr 1, 2025 that may be closed by this pull request
@jonhealy1 jonhealy1 requested review from jonhealy1 and Copilot April 7, 2025 05:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

stac_fastapi/opensearch/stac_fastapi/opensearch/config.py:20

  • Consider providing a default value or null-check for 'ES_HOST' to avoid errors if the environment variable is not set.
for host in os.getenv("ES_HOST").split(",")

stac_fastapi/elasticsearch/stac_fastapi/elasticsearch/config.py:21

  • Consider providing a default value or null-check for 'ES_HOST' to avoid errors if the environment variable is not set.
for host in os.getenv("ES_HOST").split(",")

Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Thanks @StijnCaerts

@jonhealy1 jonhealy1 merged commit dffba5d into stac-utils:main Apr 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please enable http_compress by default
2 participants