Local emulator #422
Local emulator #422
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| find /app/apps -type f -exec sed -i "s/$escaped_key/$escaped_value/g" {} + | ||
|
|
||
| # Replace the sentinel with the value | ||
| find /app/apps -type f -exec sed -i "s/$escaped_sentinel/$escaped_value/g" {} + |
There was a problem hiding this comment.
The sed substitution uses '/' as a delimiter but the replacement string (escaped_value) may contain forward slashes. Consider using an alternate delimiter (e.g., |) or also escaping '/' to avoid substitution errors.
| find /app/apps -type f -exec sed -i "s/$escaped_sentinel/$escaped_value/g" {} + | |
| find /app/apps -type f -exec sed -i "s|$escaped_sentinel|$escaped_value|g" {} + |
There was a problem hiding this comment.
yep this is potentially pretty severe. I don't think | protects enough against malicious actors still, but idk what does
N2D4
left a comment
N2D4
left a comment
There was a problem hiding this comment.
can you create a new PR with these fixes, and also the fixes from earlier, and then add me as a reviewer?
| {getPublicEnvVar('NEXT_PUBLIC_STACK_EMULATOR_ENABLED') === 'true' ? ( | ||
| <SettingCard | ||
| title="Mock Emails" | ||
| description="All the emails that are sent in the emulator will land here" |
There was a problem hiding this comment.
Remove "the" in "All the emails"
| find /app/apps -type f -exec sed -i "s/$escaped_key/$escaped_value/g" {} + | ||
|
|
||
| # Replace the sentinel with the value | ||
| find /app/apps -type f -exec sed -i "s/$escaped_sentinel/$escaped_value/g" {} + |
There was a problem hiding this comment.
yep this is potentially pretty severe. I don't think | protects enough against malicious actors still, but idk what does
Important
Introduces a local emulator setup for Stack with Docker configurations, environment variable handling improvements, and ESLint rule updates.
docker/emulator/docker.compose.yamlfor local emulator services including Stack Auth Server, Mock OAuth Server, PostgreSQL, Inbucket, and Svix.docker/mock-oauth-server/Dockerfileto build the mock OAuth server.docker/emulator/inbucket-nginx.conffor Inbucket proxy configuration.getPublicEnvVar()inpackages/stack-shared/src/utils/env.tsxfor accessing public environment variables.process.envaccess withgetPublicEnvVar()in multiple files includingsentry.client.config.tsandstack.tsx.no-next-public-envrule ineslint-configs/extra-rules.jsto enforce usinggetPublicEnvVar()..eslintrc.cjsfiles across the project.apps/oauth-mock-servertoapps/mock-oauth-server.package.jsonandindex.tsinmock-oauth-serverto reflect changes.e2e-api-tests.yamlto use new Docker Compose paths.src/lib/env.tsxindashboardand replaced its functionality with shared utilities.This description was created by
for 5103b88. It will automatically update as commits are pushed.