Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate existing patch series to patchable #1005

Merged
merged 33 commits into from
Feb 27, 2025
Merged

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Feb 17, 2025

Description

Fixes #1004

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

Preview Give feedback
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@nightkr
Copy link
Member Author

nightkr commented Feb 19, 2025

All products have now been converted except for NiFi, since #1006 partially tackles that. Will normalize NiFi after that PR is merged.

@nightkr
Copy link
Member Author

nightkr commented Feb 20, 2025

Converted/normalized NiFi as well, now that #1006 is in.

@nightkr nightkr marked this pull request as ready for review February 20, 2025 11:09
@nightkr nightkr requested review from a team and NickLarsenNZ February 20, 2025 11:09
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few remarks:

  • This patch file contains "Subject" in the subject and the filename.
  • Patches for non-product components are not migrated yet: Phoenix, hbase-operator-tools and hbase-connectors. Also, maybe we need to align the folder structure for these components at some point. But I'd say the restructuring does not need be part of this PR, it can be done when implementing the solution for https://github.com/stackabletech/decisions/issues/44. If it makes things easier we could also do it in this PR, not sure what's the best solution though.
  • We'll need to remove Druid 26 and migrate the patches for 30.0.1 and 31.0.1 after this is merged (should happen soon, is waiting for review). Can also happen in a follow up PR or in the PR for Druid.

@nightkr
Copy link
Member Author

nightkr commented Feb 27, 2025

fmpp: 7149c0e

Other components: yeah, I think I'd want to migrate them to use the same structure.. I'd say leave it to a future PR since this one is already way too massive as it is.

Druid: Good catch, are you okay backporting that into #984?

Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

LGTM now 🙂

@nightkr nightkr added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit 9f505c4 Feb 27, 2025
3 checks passed
@nightkr nightkr deleted the feature/patchable-migration branch February 27, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate existing patch series to patchable
2 participants