-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate existing patch series to patchable #1005
Conversation
All products have now been converted except for NiFi, since #1006 partially tackles that. Will normalize NiFi after that PR is merged. |
Converted/normalized NiFi as well, now that #1006 is in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few remarks:
- This patch file contains "Subject" in the subject and the filename.
- Patches for non-product components are not migrated yet: Phoenix, hbase-operator-tools and hbase-connectors. Also, maybe we need to align the folder structure for these components at some point. But I'd say the restructuring does not need be part of this PR, it can be done when implementing the solution for https://github.com/stackabletech/decisions/issues/44. If it makes things easier we could also do it in this PR, not sure what's the best solution though.
- We'll need to remove Druid 26 and migrate the patches for 30.0.1 and 31.0.1 after this is merged (should happen soon, is waiting for review). Can also happen in a follow up PR or in the PR for Druid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
LGTM now 🙂
Description
Fixes #1004
Definition of Done Checklist
Tasks
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
bake
to retrieve the image tag for<image-tagged-with-the-major-version>
.