Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDFS: Allow overriding datanode registration addresses #506

Merged
merged 7 commits into from
Jan 11, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Nov 16, 2023

Description

Part of stackabletech/hdfs-operator#174, implemented by rebuilding HDFS from source, after applying the required patches.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

Preview Give feedback

@nightkr nightkr marked this pull request as ready for review January 11, 2024 11:12
@nightkr nightkr requested a review from a team January 11, 2024 11:13
@nightkr
Copy link
Member Author

nightkr commented Jan 11, 2024

The 3.3.4 variant is tested against stackabletech/hdfs-operator@2cd93ad. The 3.3.6 variant is untested due to stackabletech/hdfs-operator#440.

There is no 3.2.x backport, on the hypothesis that any new clusters should be running 3.3.x+, and any existing clusters have clearly already been fine without external access.. :P

stackabletech/hdfs-operator#450 should not break in-cluster access to HDFSes without this patch applied (they would silently ignore the override, falling back to the cluster-internal address).

@siegfriedweber siegfriedweber requested review from siegfriedweber and removed request for a team January 11, 2024 11:26
siegfriedweber
siegfriedweber previously approved these changes Jan 11, 2024
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

You could add this to the changelog.

@nightkr
Copy link
Member Author

nightkr commented Jan 11, 2024

Good catch, will do.

@nightkr
Copy link
Member Author

nightkr commented Jan 11, 2024

@siegfriedweber 242cbd8

@nightkr nightkr enabled auto-merge January 11, 2024 13:00
@nightkr nightkr added this pull request to the merge queue Jan 11, 2024
Merged via the queue into main with commit 5281ce1 Jan 11, 2024
12 checks passed
@nightkr nightkr deleted the feature/hdfs-listener branch January 11, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants