Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Adopt breaking changes from HDFS listener integration #442

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix(tests): Adopt breaking changes from HDFS listener integration #442

merged 1 commit into from
Jan 29, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 29, 2024 •
edited by fhennig
Loading

Description

Breaking changes from stackabletech/hdfs-operator#450

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer
Copy link
Member Author

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hbase-operator-it-custom/134/

fhennig
fhennig approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer requested a review from nightkr January 29, 2024 09:58
@sbernauer sbernauer added this pull request to the merge queue Jan 29, 2024
nightkr
nightkr approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it locally, but in theory it LGTM.

One note: I'd expect namenode and datanode to be on different listenerclasses (for external use cases), typically with namenodes on external-stable and datanodes on external-unstable.

Merged via the queue into main with commit be0c3f4 Jan 29, 2024
30 checks passed
@sbernauer sbernauer deleted the fix/tests branch January 29, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr approved these changes

@fhennig fhennig fhennig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @nightkr @fhennig