-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support for hbase 2.6.1 #627
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indeed, it seems there is no workaround to the checksum problem currently. The tests are green:
|
razvan
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a small fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/docker-images#972
I had to add the
--no-checksum-verify
flag when exporting snapshots to/from S3, because oursnapshot-export
test was failing for HBase 2.6.1.From what I see, checksum verification was merged and released with 2.6.1: https://issues.apache.org/jira/browse/HBASE-28625
However, it seems to have problems when comparing snapshots on different filesystems (like HDFS and S3).
https://issues.apache.org/jira/browse/HBASE-28702 was also merged into 2.6.1 and seems to introduce a flag to skip checksum-checks between snapshots when exporting tables. I'm not sure if this flag is supposed to work with snapshot exports as well, at least I could not make it work. Setting
fs.checksum.combine.mode
toCOMPOSITE_CRC
also does not seem to work.https://issues.apache.org/jira/browse/HBASE-28998 (still open) also mentions that it does not work with
COMPOSITE_CRC
and it specificly mentions problems with HDFS in combination with S3.So I decided to add the
--no-checksum-verify
flag in our tests when exporting snapshots. From what I understand snapshot checksums where not validated before 2.6.1 either. I don't have too much experience with HBase and thus am not sure if this is really the best solution. Could one of our HBase experts (@razvan @siegfriedweber @lfrancke ?) take a look at this as well? If this solution is fine I would adapt the documentation accordingly.Definition of Done Checklist
Author
Reviewer
Acceptance