Remove MergedConfig

[nightkr]

Description

Fixes #456.

This is intended to solve two things:

1. Having to add every new config field to umpteen places, adding a lot of busywork to every change (and a lot of annoying indirection when trying to chase down the real definition of everything).
2. MergedConfig containing the union of all roles' options, making it unclear which fields available when (and the especially comical case where resources exists in all variants... but still has a separate accessor method for each).

Instead, this PR delegates actually-common options to the new struct CommonNodeConfig and introduces a new enum AnyNodeConfig which users can explicitly downcast from to access role-specific options. Common options are accessible immediately because AnyNodeConfig derefs to CommonNodeConfig.

This PR replaces all uses of &dyn MergedConfig with &AnyNodeConfig to minimize impact. In the future, it's intended that new code that is only relevant for a single role should use that role's config type directly.

Definition of Done Checklist

• Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
• Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

1. Changes are OpenShift compatible
2. CRD changes approved
3. CRD documentation for all fields, following the style guide.
4. Helm chart can be installed and deployed operator works
5. Integration tests passed (for non trivial changes)
6. Changes need to be "offline" compatible

Reviewer

Preview Give feedback

1. Code contains useful comments
2. (Integration-)Test cases added
3. Documentation added or updated. Follows the style guide.
4. Changelog updated
5. Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

Preview Give feedback

1. Feature Tracker has been updated
2. Proper release label has been added

[razvan]

nice. maybe an entry in the change log would be nice, even if it's not user facing.

[nightkr]

I would argue that these externally invisible changes don't make sense to add, "refactored MergedConfig" isn't something that tells a user.. anything.

[razvan]

This is probably a discipline vs. common sense discussion. I can get behind both arguments, just mentioned it because it's a checkbox for the reviewer.