Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back dummy .spec.clusterConfig.listenerClass #462

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Add back dummy .spec.clusterConfig.listenerClass #462

merged 4 commits into from
Jan 29, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jan 29, 2024 •
edited
Loading

Description

Fixes #461

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback
No tasks being tracked yet.

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@nightkr nightkr requested review from sbernauer, soenkeliebau and a team January 29, 2024 10:11
sbernauer
sbernauer requested changes Jan 29, 2024
View reviewed changes
@nightkr nightkr requested a review from sbernauer January 29, 2024 13:42
sbernauer
sbernauer previously approved these changes Jan 29, 2024
View reviewed changes
@nightkr nightkr added this pull request to the merge queue Jan 29, 2024
@sbernauer sbernauer removed this pull request from the merge queue due to a manual request Jan 29, 2024
@sbernauer sbernauer enabled auto-merge January 29, 2024 14:01
@sbernauer sbernauer added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit fa09321 Jan 29, 2024
30 checks passed
@sbernauer sbernauer deleted the bugfix/cluster-listener-class branch January 29, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

@soenkeliebau soenkeliebau Awaiting requested review from soenkeliebau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reintroduce dummy .spec.clusterConfig.listenerClass
2 participants
@nightkr @sbernauer