Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use flow.json.gz to easily migrate to version 2.0 #675

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Conversation

razvan
Copy link
Member

@razvan razvan commented Sep 17, 2024

Description

part of: stackabletech/docker-images#836

https://stackable-workspace.slack.com/archives/C031NP72H7T/p1726502134517489

The older flow.xml.gz format was deprecated as of Apache NiFi 1.16 in favor of the newer flow.json.gz format. NiFi 1.16+ will only load the flow.xml.gz if the flow.json.gz does not already exist during startup. Upon successful startup, NiFi will generate the flow.json.gz. The NiFi 1.16+ version will still generate both the flow.xml.gz and flow.json.gz formats with every change made on the UI.
With the major release of Apache NiFi 2.x, the deprecated flow.xml.gz format was removed.
There is no option in NiFi 2.0 to support the older flow.xml.gz format.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@razvan razvan marked this pull request as ready for review September 17, 2024 08:17
@razvan
Copy link
Member Author

razvan commented Sep 17, 2024

@razvan razvan requested a review from sbernauer September 17, 2024 08:23
sbernauer
sbernauer previously approved these changes Sep 17, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Can we please also have a backport into the 24.7 docs that state Currently you can not update from NiFi 1.27 to 2.0! This upgrade path is supported starting with SDP version 24.11

Co-authored-by: Sebastian Bernauer <[email protected]>
@razvan razvan requested a review from sbernauer September 17, 2024 08:54
@razvan razvan enabled auto-merge September 17, 2024 08:54
@sbernauer sbernauer disabled auto-merge September 17, 2024 08:58
sbernauer
sbernauer previously approved these changes Sep 17, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the auto-merge because the Jenkins test failed, we need to look into that

@razvan
Copy link
Member Author

razvan commented Sep 17, 2024

I removed the auto-merge because the Jenkins test failed, we need to look into that

The upgrade test failed, which worked on my machine (tm)

@sbernauer
Copy link
Member

@razvan
Copy link
Member Author

razvan commented Sep 17, 2024

@razvan
Copy link
Member Author

razvan commented Sep 17, 2024

Local test:

-- PASS: kuttl (497.95s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/upgrade_zookeeper-latest-3.9.2_nifi_old-1.27.0_nifi_new-2.0.0-M4_openshift-false (496.37s)
PASS

@razvan razvan requested a review from sbernauer September 17, 2024 12:35
@razvan razvan enabled auto-merge September 17, 2024 13:05
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@razvan razvan requested a review from sbernauer September 17, 2024 14:24
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@razvan razvan added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 3bcd33e Sep 18, 2024
31 checks passed
@razvan razvan deleted the chore/nifi-24.11 branch September 18, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants