Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow k8s administrators to override ZNode path #681

Closed
Tracked by #25
nightkr opened this issue May 11, 2023 · 9 comments · Fixed by #799
Closed
Tracked by #25

Allow k8s administrators to override ZNode path #681

nightkr opened this issue May 11, 2023 · 9 comments · Fixed by #799

Comments

@nightkr
Copy link
Member

nightkr commented May 11, 2023

This is currently not allowed because it would let users escalate "Is allowed to create sandboxed ZNodes" to "Is allowed to take ownership of any named ZNode".

However, this is preventing users from restoring failed clusters from backups, since there is no way to influence the UID generation at all. One possible compromise would be to introduce a new field ZookeeperZnode.status.znodePath, which defaults to /{uid}. This would let administrators status-patch the object to override the path, while regular users are typically prohibited (by K8s) from editing the status subresource.

@nightkr nightkr self-assigned this Mar 25, 2024
@nightkr nightkr moved this to Development: In Progress in Stackable Engineering Mar 25, 2024
@sbernauer
Copy link
Member

LGTM

@nightkr
Copy link
Member Author

nightkr commented Apr 10, 2024

Moving this into the voting phase.

@nightkr
Copy link
Member Author

nightkr commented Apr 17, 2024

No dissent, considering this accepted.

@nightkr nightkr moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Apr 26, 2024
@nightkr nightkr moved this from Development: Waiting for Review to Development: Done in Stackable Engineering May 2, 2024
@lfrancke
Copy link
Member

lfrancke commented May 6, 2024

Is this anything we documented?

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering May 6, 2024
@sbernauer
Copy link
Member

Is this already implemented? #799 looks like the implementation and is not merged yet

@lfrancke
Copy link
Member

lfrancke commented May 6, 2024

I don't know. I found this in the Done column

@nightkr
Copy link
Member Author

nightkr commented May 16, 2024

Not sure how this got moved to done, #799 has indeed not been reviewed yet.

Is this anything we documented?

It's documented in the PR, but since that still hasn't been merged...

@nightkr nightkr reopened this May 16, 2024
@nightkr nightkr moved this from Acceptance: In Progress to Development: Waiting for Review in Stackable Engineering May 16, 2024
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 27, 2024
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jun 21, 2024
@lfrancke
Copy link
Member

As this has been merged now, can you please include a link to the generated docs?

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Jun 26, 2024
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants