Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding ZNode path #799

Merged
merged 13 commits into from
Jun 20, 2024
Merged

Allow overriding ZNode path #799

merged 13 commits into from
Jun 20, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Apr 4, 2024

Description

Fixes #681

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@nightkr nightkr requested a review from a team April 5, 2024 00:04
@nightkr
Copy link
Member Author

nightkr commented Apr 5, 2024

Some integration tests are currently failing due to a missing spec.image, not sure if it's related to https://stackable-workspace.slack.com/archives/C02M1RE8S0Z/p1712274080585689.

@nightkr
Copy link
Member Author

nightkr commented Apr 26, 2024

Turns out the test failures were due to stale beku work files. Clearing tests/_work made them pass.

@nightkr nightkr marked this pull request as ready for review April 26, 2024 15:39
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Co-authored-by: Sebastian Bernauer <[email protected]>
@nightkr nightkr requested a review from sbernauer June 3, 2024 12:49
sbernauer
sbernauer previously approved these changes Jun 3, 2024
@nightkr nightkr added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit f11c86a Jun 20, 2024
32 checks passed
@nightkr nightkr deleted the feature/znode-path-override branch June 20, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow k8s administrators to override ZNode path
3 participants