Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support configuring JVM arguments #919

Merged
merged 4 commits into from
Feb 27, 2025
Merged

feat: Support configuring JVM arguments #919

merged 4 commits into from
Feb 27, 2025

Conversation

sbernauer
Copy link
Member

Description

Part of stackabletech/issues#584

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@maltesander maltesander self-requested a review February 26, 2025 13:57
@sbernauer
Copy link
Member Author

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking, LGTM otherwise.

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit e01bf3d Feb 27, 2025
17 checks passed
@sbernauer sbernauer deleted the feat/jvm-arguments branch February 27, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants