Closed
Conversation
… as BIGINT; cleanup: better names, removed redundant code
…terIcon hints at clickability
8 tasks
huumn
reviewed
Dec 29, 2024
Member
huumn
left a comment
There was a problem hiding this comment.
Code looks simple and clean. I'll QA and do UI review tomorrow.
huumn
approved these changes
Dec 30, 2024
Member
huumn
left a comment
There was a problem hiding this comment.
This is great.
I won't merge until after Jan. 3, and I might end up tweaking the UI and save the notification filters to localstoage for reuse, but consider it done - I'll pay up in the next few days.
Member
Author
|
I knew I was forgetting something, filter persistence! I could go and do it right away^^ |
825a566 to
0c1b64b
Compare
188aa17 to
dfa3e07
Compare
dfa3e07 to
7a8ed9b
Compare
81fc06f to
05e7057
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds filtering by type for Notifications completing #1035
Types are represented by categories that are defined and ordered in
lib/constants.jsLike Satistics, it relies on
router.queryto apply and retrieve filters (a user can bookmark the URL).Unlike it, the modal enables multi-select before applying filters and it uses
router.replaceinstead ofrouter.pushto maintain interoperability with the existing notifications pageWhen filters are applied,
localStorageis updated with values set by the user and/orrouter.query.inc. If filters haven't been reset, on next visits users can re-apply the last filters they choseScreenshots
Notifications page

Default modal, no filters

Modal with filters

Mobile modal

Notifications page with filters on

Additional Context
SubStatus.name as idand casting NULLearnedSatsvalues toBIGINTwas necessary to make queries work on their own, could this be a problem? Notifications works as usual :PAlso I couldn't find a query for
JobChangedso I left it as-isFilters hue for light mode maybe needs to be changed?
--theme-brandColorChecklist
Are your changes backwards compatible? Please answer below: Yes!
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7, I couldn't reproduce some notification types! Other than that, filtering consistently works and when no filters are applied, notifications follow the same behavior as before.
For frontend changes: Tested on mobile, light and dark mode? Please answer below: Tested on mobile, PWA and also in light (additional context) and dark mode.
Did you introduce any new environment variables? If so, call them out explicitly here: No
Progress