Bugfix - grubcmdline reboot detection triggered by empty values in list #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #17. @jjo93sa 's fix correctly manages empty values for the grub.cfg, but a reboot signal is still sent by:
changed_when: old_cmdline != kernel_cmdline | sort | list
There are two things that break the comparison:
Firstly:
kernel_cmdline | sort | list
contains the empty valuesand then, the empty values break the kernel_cmdline_regex filter here:
old_cmdline: "{{ result.stdout.split() | select('search', kernel_cmdline_regex) | sort | list }}"
and old_cmdline is then populated with the full /proc/cmdline:
rather than the expected