Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address CI comments #347

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Address CI comments #347

merged 2 commits into from
Feb 20, 2024

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Jan 3, 2024

Fixes #251

@sjpb
Copy link
Collaborator Author

sjpb commented Jan 3, 2024

Image build workflow succeeded: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/7396296651

@sjpb sjpb marked this pull request as ready for review January 4, 2024 09:41
@sjpb sjpb requested a review from a team as a code owner January 4, 2024 09:41
m-bull
m-bull approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit e0c0932 into main Feb 20, 2024
2 checks passed
@sjpb sjpb deleted the ci/nits branch February 20, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bull m-bull m-bull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI nits
2 participants
@sjpb @m-bull