Remove special-case for firewalld in builder #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fat image build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/8192527716 Edit: succeeded, |
|
Canceled workflow, rebuilding image for safety: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/8201785642: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses extravars instead of a workaround in
fatimage.ymlto ensure firewalld service is not enabled on all nodes, to minimise differences/changes of error between fatimage.yml and site.ymlBackground for future reference:
ansible/bootstrap.ymlis run by bothsite.ymlandfatimage.ymlThis runs thefirewalldrole which dnf-installs firewalld . On install, the firewalld service is enabled so after a reboot it starts running. Hence by default firewalld ends up running on all nodes created with a fatimage, even though its only wanted on the login node(s) running fail2ban. Before this PR there was a workaround in fatimage.yml to explicitly disable it on build.Requires new image build.