Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve leafcloud CI support #374

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Improve leafcloud CI support #374

merged 4 commits into from
Mar 7, 2024

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Mar 1, 2024 •
edited
Loading

  • use proper leafcloud jumphost user
  • get packer build working
  • move to stackhpc-ci project (no visible change in repo)

@sjpb sjpb marked this pull request as ready for review March 6, 2024 09:14
@sjpb sjpb requested a review from a team as a code owner March 6, 2024 09:14
@sjpb sjpb changed the title WIP: Improve leafcloud Improve leafcloud CI support Mar 6, 2024
@m-bull
Copy link
Collaborator

m-bull commented Mar 7, 2024

This looks fine. General question really - do we need to use a bastion here?

m-bull
m-bull approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 6ca97fe into main Mar 7, 2024
1 check passed
@sjpb sjpb deleted the ci/leafcloud branch March 7, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bull m-bull m-bull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjpb @m-bull