Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower hpl memory fraction to reduce stress from defaults #591

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Lower hpl memory fraction to reduce stress from defaults #591

merged 2 commits into from
Feb 20, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Feb 20, 2025

No description provided.

@sjpb sjpb marked this pull request as ready for review February 20, 2025 12:03
@sjpb sjpb requested a review from a team as a code owner February 20, 2025 12:03
JohnGarbutt
JohnGarbutt approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

jovial
jovial approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to implement what we have discussed internally. Will we still have long runtimes on nodes with a lot of memory? Would we be better off capping the max ram to some low value? E.g

min(30% ram, 32GB)

@sjpb
Copy link
Collaborator Author

sjpb commented Feb 20, 2025

I don't think its worth it TBH.

@sjpb sjpb merged commit c688e3a into main Feb 20, 2025
1 of 2 checks passed
@sjpb sjpb deleted the fix/hpl-no-fires branch February 20, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnGarbutt JohnGarbutt JohnGarbutt approved these changes

@jovial jovial jovial approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjpb @JohnGarbutt @jovial