Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct path when normalising files #63

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

jackhodgkiss
Copy link
Contributor

Due to a previous addition of adding support for parallel configuration generation when producing a config-diff there is an unfortunate side effect whereby some files such as fluentd contain the different paths they were produced from. This causes false positives in config-diff.

The change had included a fix however the wrong folder to search was specified.

Due to a previous addition of adding support for parallel configuration generation when producing a config-diff there is an unfortunate side effect whereby some files such as fluentd contain the different paths they were produced from. This causes false positives in config-diff.

The change had included a fix however the wrong folder to search was specified.
@jackhodgkiss jackhodgkiss added the bug Something isn't working label Aug 20, 2024
@jackhodgkiss jackhodgkiss self-assigned this Aug 20, 2024
@jackhodgkiss jackhodgkiss requested a review from a team as a code owner August 20, 2024 13:14
@jackhodgkiss jackhodgkiss merged commit 7eefdb9 into main Aug 20, 2024
4 checks passed
@jackhodgkiss jackhodgkiss deleted the fix-config-normalisation branch August 20, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants