Skip to content

Commit

Permalink
Merge pull request #685 from stackhpc/upstream/master-2025-02-24
Browse files Browse the repository at this point in the history
Synchronise master with upstream
  • Loading branch information
priteau authored Feb 24, 2025
2 parents 3e0e918 + f150be4 commit 4cbf2ee
Show file tree
Hide file tree
Showing 11 changed files with 22 additions and 44 deletions.
1 change: 1 addition & 0 deletions ansible/roles/cinder/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ cinder_backend_pure_nvme_tcp_name: "Pure-FlashArray-nvme-tcp"

cinder_ceph_backends:
- name: "{{ cinder_backend_ceph_name }}"
backend_name: "{{ cinder_backend_ceph_name }}"
cluster: "{{ ceph_cluster }}"
user: "{{ ceph_cinder_user }}"
pool: "{{ ceph_cinder_pool_name }}"
Expand Down
7 changes: 0 additions & 7 deletions ansible/roles/cinder/tasks/upgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,6 @@

- import_tasks: check-containers.yml

# TODO(bbezak): Remove this task in the Dalmatian cycle.
- import_role:
name: service-ks-register
vars:
service_ks_register_auth: "{{ openstack_cinder_auth }}"
service_ks_register_user_roles: "{{ cinder_ks_user_roles }}"

- name: Flush handlers
meta: flush_handlers

Expand Down
2 changes: 1 addition & 1 deletion ansible/roles/cinder/templates/cinder.conf.j2
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ target_protocol = iscsi
{% for backend in cinder_ceph_backends %}
[{{ backend.name }}]
volume_driver = cinder.volume.drivers.rbd.RBDDriver
volume_backend_name = {{ backend.name }}
volume_backend_name = {{ backend.backend_name | default(backend.name) }}
rbd_pool = {{ backend.pool }}
rbd_ceph_conf = /etc/ceph/{{ backend.cluster }}.conf
rados_connect_timeout = 5
Expand Down
7 changes: 0 additions & 7 deletions ansible/roles/ironic/tasks/upgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,3 @@

- include_tasks: legacy_upgrade.yml
when: not ironic_enable_rolling_upgrade | bool

# TODO(bbezak): Remove this task in the Dalmatian cycle.
- import_role:
name: service-ks-register
vars:
service_ks_register_auth: "{{ openstack_ironic_auth }}"
service_ks_register_user_roles: "{{ ironic_ks_user_roles }}"
7 changes: 0 additions & 7 deletions ansible/roles/nova/tasks/upgrade.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
---
# TODO(bbezak): Remove this task in the Dalmatian cycle.
- import_role:
name: service-ks-register
vars:
service_ks_register_auth: "{{ openstack_nova_auth }}"
service_ks_register_user_roles: "{{ nova_ks_user_roles }}"

# Create new set of configs on nodes
- import_tasks: config.yml

Expand Down
6 changes: 3 additions & 3 deletions ansible/roles/prometheus/templates/prometheus.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -178,17 +178,17 @@ scrape_configs:
{% endfor %}
relabel_configs:
- source_labels: [__address__]
regex: (\w+):(\w+):(.+)
regex: ([^:]+):([^:]+):(.+)
target_label: service
replacement: ${1}
- source_labels: [__address__]
regex: (\w+):(\w+):(.+)
regex: ([^:]+):([^:]+):(.+)
target_label: __param_module
replacement: ${2}
- source_labels: [__param_module]
target_label: module
- source_labels: [__address__]
regex: (\w+):(\w+):(.+)
regex: ([^:]+):([^:]+):(.+)
target_label: __param_target
replacement: ${3}
- source_labels: [__param_target]
Expand Down
4 changes: 2 additions & 2 deletions doc/source/reference/networking/neutron.rst
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,15 @@ provisioning, controllers might have access to two physical networks:
neutron_external_interface: "eth1,eth2"
neutron_bridge_name: "br-ex1,br-ex2"
neutron_physical_network: "physnet1,physnet2"
neutron_physical_networks: "physnet1,physnet2"
While compute nodes have access only to ``physnet2``.

.. code-block:: yaml
neutron_external_interface: "eth1"
neutron_bridge_name: "br-ex1"
neutron_physical_network: "physnet2"
neutron_physical_networks: "physnet2"
Example: shared interface
-------------------------
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
features:
- |
Added support for explicitly setting ``volume_backend_name`` for
Cinder Ceph backends by the new variable ``backend_name`` in
the ``cinder_ceph_backends`` dictionary configuration.
7 changes: 7 additions & 0 deletions releasenotes/notes/fix-blackbox-regex-b16f3f86563de6db.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
fixes:
- |
Fixes the regex used to match blackbox exporter targets in the
``prometheus.yml.j2`` template to be less strict. Previously we were using
``\w`` which did not allow for names with periods or hyphens. The service
and module labels can now contain all characters except for a colon.
11 changes: 2 additions & 9 deletions tests/run.yml
Original file line number Diff line number Diff line change
Expand Up @@ -202,17 +202,13 @@
mode: 0777

- name: Download Ironic Python Agent (IPA) images
vars:
# TODO(mnasiadka): Revert back to master when it works
# tinyipa_image: "tinyipa-{{ zuul.branch | replace('/', '-') }}"
tinyipa_image: "tinyipa-stable-2024.2"
get_url:
url: "https://tarballs.opendev.org/openstack/ironic-python-agent/tinyipa/files/{{ item.src }}"
dest: "/etc/kolla/config/ironic/{{ item.dest }}"
with_items:
- src: "{{ tinyipa_image }}.gz"
- src: "tinyipa-{{ zuul.branch | replace('/', '-') }}.gz"
dest: ironic-agent.initramfs
- src: "{{ tinyipa_image }}.vmlinuz"
- src: "tinyipa-{{ zuul.branch | replace('/', '-') }}.vmlinuz"
dest: ironic-agent.kernel
when: scenario == "ironic"

Expand Down Expand Up @@ -670,14 +666,11 @@
vars:
ansible_core_version_constraint: >-
{{ ansible_core_version_min if is_upgrade or base_distro != 'ubuntu' else ansible_core_version_max }}
ansible_version_constraint: >-
{{ ansible_version_min if is_upgrade or base_distro != 'ubuntu' else ansible_version_max }}
pip:
extra_args: "-c {{ upper_constraints_file }}"
name:
- "{{ kolla_ansible_src_dir }}"
- "ansible-core{{ ansible_core_version_constraint }}"
- "ansible{{ ansible_version_constraint }}"
- "ara<1.0.0"
virtualenv: "{{ kolla_ansible_venv_path }}"
when: is_slurp
Expand Down
8 changes: 0 additions & 8 deletions zuul.d/base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,6 @@
ansible_core_version_slurp: "==2.16.*"
ansible_core_version_max: "==2.17.*"
ansible_core_version_min: "==2.16.*"
# Test latest ansible-core version on Ubuntu, minimum supported on others.
# Use SLURP version (two releases back) on SLURP upgrades.
# TODO(mnasiadka): Remove in D.
ansible_version_constraint: >-
{{ ansible_version_slurp if is_slurp else ansible_version_min if is_upgrade or ansible_facts.distribution != "Ubuntu" else ansible_version_max }}
ansible_version_slurp: "==9.*"
ansible_version_min: "==9.*"
ansible_version_max: "==10.*"
# NOTE(mgoddard): Test the use of interface names with dashes.
api_interface_name: "vxlan-0"
api_network_prefix: "192.0.2."
Expand Down

0 comments on commit 4cbf2ee

Please sign in to comment.