Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tagging policy engine [OSSA-2024-005] #192

Open
wants to merge 1 commit into
base: stackhpc/zed
Choose a base branch
from

Conversation

m-bull
Copy link

@m-bull m-bull commented Dec 5, 2024

The service tagging policy engine should consider the parent resource or the upper parent resource project ID when checking the policies against the caller project ID.

Before this patch, as introduced in [1], the target was incorrectly populated with the caller project ID instead of using the resource ID.

[1]https://review.opendev.org/c/openstack/neutron/+/896509/13/neutron/extensions/tagging.py

OSSA-2024-005 CVE-2024-53916

Closes-Bug: #2088986
Change-Id: Id7d0c8e7ba37993b1084519d05e7e2eac095b81b (cherry picked from commit fb75d3c)

The service tagging policy engine should consider the parent resource or
the upper parent resource project ID when checking the policies against
the caller project ID.

Before this patch, as introduced in [1], the target was incorrectly
populated with the caller project ID instead of using the resource ID.

[1]https://review.opendev.org/c/openstack/neutron/+/896509/13/neutron/extensions/tagging.py

OSSA-2024-005 CVE-2024-53916

Closes-Bug: #2088986
Change-Id: Id7d0c8e7ba37993b1084519d05e7e2eac095b81b
(cherry picked from commit fb75d3c)
@m-bull m-bull requested a review from a team as a code owner December 5, 2024 12:40
@m-bull
Copy link
Author

m-bull commented Dec 5, 2024

======
Totals
======
Ran: 20231 tests in 1149.8987 sec.
 - Passed: 18657
 - Skipped: 1574
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 0
Sum of execute time for each test: 9001.3361 sec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants