fix: use rabbitmq length for RabbitMQNodeDown
#1579
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
monitoring
MoteHue
requested changes
Mar 20, 2025
| @@ -6,7 +6,7 @@ groups: | |||
| - name: rabbitmq.rules | |||
| rules: | |||
| - alert: RabbitMQNodeDown | |||
| expr: sum(rabbitmq_build_info{instance!=""}) < 3 | |||
| expr: sum(rabbitmq_build_info{instance!=""}) < {% endraw %}{{ groups['controllers'] | length }}{% raw %} | |||
There was a problem hiding this comment.
Is it possible to use the rabbitmq group from here instead? https://github.com/openstack/kayobe/blob/master/ansible/roles/kolla-ansible/templates/overcloud-components.j2#L62
Just thinking this wouldn't work if anyone has moved RabbitMQ to a different group
jovial
reviewed
Mar 20, 2025
| @@ -6,7 +6,7 @@ groups: | |||
| - name: rabbitmq.rules | |||
| rules: | |||
| - alert: RabbitMQNodeDown | |||
| expr: sum(rabbitmq_build_info{instance!=""}) < 3 | |||
| expr: sum(rabbitmq_build_info{instance!=""}) < {% endraw %}{{ groups['controllers'] | length }}{% raw %} | |||
There was a problem hiding this comment.
I think you could potentially use the rabbitmq group here since the templating is within a raw tag and thus templated by kolla-ansible
The `RabbitMQNodeDown` made the assumption that all deployments involve only three RabbitMQ nodes. However, this is not always the case as we do support deployments with a single node or more than three. Before this would have caused false alerts in deployments with a single RabbitMQ node. Whilst also concealing alerts in deployments with more than three nodes.
jackhodgkiss
force-pushed
the
fix-rabbitmq-node-down-rule
branch
from
61b564c to
e183052
Compare
jackhodgkiss
changed the title
controller length for RabbitMQNodeDownrabbitmq length for RabbitMQNodeDown
MoteHue
requested changes
Mar 24, 2025
Co-authored-by: Matt Crees <[email protected]>
MoteHue
approved these changes
Mar 24, 2025
|
This fails to template correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RabbitMQNodeDownmade the assumption that all deployments involve three controllers. However, this is not always the case as we do support deployments with a single controller or more than three controllers.Before this would have caused false alerts in deployments with a single controller. Whilst also concealing alerts in deployments with more than three controllers.