Skip to content

Bump .terraform.lock.hcl and remove upgrade flag - #491

Merged
priteau merged 1 commit into
mainfrom
terraform-init-no-upgrade
Nov 13, 2026
Merged

priteau merged 1 commit into
mainfrom
terraform-init-no-upgrade

Conversation

@priteau

@priteau priteau commented Mar 12, 2026

Copy link
Copy Markdown
Member

This is not required now that we have merged the provider version bump.

@priteau priteau self-assigned this Mar 12, 2026
@priteau
priteau requested a review from a team as a code owner March 12, 2026 10:19
@priteau
priteau marked this pull request as draft March 12, 2026 10:47
@priteau
priteau force-pushed the terraform-init-no-upgrade branch from 4e05914 to b5c9107 Compare November 13, 2026 14:29
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
Summary

This pull request changes one file, .github/workflows/terraform-github.yml. It removes the -upgrade flag from the terraform init step in the workflow. The provider version bump is already merged, so the flag is no longer needed.

The Terraform initialisation step in the GitHub Actions workflow now runs terraform init without the -upgrade option.

Changes: Terraform initialisation

Layer / File(s) Summary
Terraform initialisation command
.github/workflows/terraform-github.yml
The workflow runs terraform init without the -upgrade option.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: High · previous review b5c91

With -upgrade removed and the provider lock file still pinned to 4.28.0, the Terraform GitHub workflow fails at the init step, as the failing CI run shows. Regenerate and commit the lock file for provider 6.13.0 before merging, or keep -upgrade until then.

Pre-merge checks: Passed 2

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 93aea7b and b5c9107.

Files selected for processing: 1

  • .github/workflows/terraform-github.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread .github/workflows/terraform-github.yml Resolved
@priteau
priteau force-pushed the terraform-init-no-upgrade branch from b5c9107 to 37fe139 Compare November 13, 2026 14:41
@stackhpc stackhpc deleted a comment from gemini-code-assist Bot Nov 13, 2026
@priteau
priteau marked this pull request as ready for review November 13, 2026 14:42
@priteau priteau changed the title Remove upgrade flag from terraform init Bump .terraform.lock.hcl and remove upgrade flag Nov 13, 2026
@stackhpc-ci

Copy link
Copy Markdown
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


Terraform Plan 📖success

Show Plan

undefined

Pusher: @priteau, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub

@priteau
priteau merged commit a05874a into main Nov 13, 2026
6 checks passed
@priteau
priteau deleted the terraform-init-no-upgrade branch November 13, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants