You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Prevent perpetual changes to team membership - #595
No actionable comments were generated in the recent review.
Summary
Changes terraform/github/terraform.tfvars.json only. Moves mnasiadka and priteau from Monitoring members to maintainers. Moves priteau from SRE members to maintainers. Five lines added, five removed. The file does not show organisation owner status, so it does not confirm that all owners are set to maintainer.
The Monitoring and SRE team declarations update maintainer and member assignments.
Changes: Team role updates
Layer / File(s)
Summary
Monitoring and SRE assignments terraform/github/terraform.tfvars.json
Monitoring adds mnasiadka as a maintainer and removes mnasiadka and priteau from members. SRE adds priteau as a maintainer and removes priteau from members.
The change adjusts team roles for three users so that GitHub no longer shows a perpetual diff. Nothing in the repository indicates a defect. Before applying, confirm in GitHub that these users are organisation owners.
Pre-merge checks: 2
Check name
Status
Explanation
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 8cf1dab and 6e4b0b9.
Files selected for processing: 1
terraform/github/terraform.tfvars.json
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an organization owner is given the member role they will be granted maintainer instead which will result in a perpetual diff [1].
Avoid this perpetual diff by changing status to maintainer for owners.
[1] https://registry.terraform.io/providers/integrations/github/latest/docs/resources/team_members