Skip to content

Disable Terraform coloured output - #597

Closed
priteau wants to merge 1 commit into
mainfrom
tf-nocolor
Closed

priteau wants to merge 1 commit into
mainfrom
tf-nocolor

Conversation

@priteau

@priteau priteau commented Nov 13, 2026

Copy link
Copy Markdown
Member

Coloured output is making logs hard to read. Disable it everywhere.

@priteau priteau self-assigned this Nov 13, 2026
@priteau
priteau requested a review from a team as a code owner November 13, 2026 11:49
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
Summary

The workflow removes the -no-color flags from terraform validate and terraform show. It also adds an env entry named export TF_CLI_ARGS, which is not a valid variable name, so Terraform does not receive -no-color. Coloured output is therefore not reliably disabled.

The Terraform GitHub Actions workflow sets TF_CLI_ARGS to -no-color. Validation and plan display commands no longer pass that flag directly. The plan continues to be written to plan.tmp and rendered to plan.out.

Changes: Terraform workflow

Layer / File(s) Summary
Set Terraform CLI arguments
.github/workflows/terraform-github.yml
The workflow sets TF_CLI_ARGS to -no-color. Validation and plan display commands no longer pass the flag directly. Plan output continues to be rendered from plan.tmp to plan.out.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: Low · previous review a838f

The change does not achieve its goal of disabling coloured Terraform output, and some commands may now print colour codes in CI logs. Fixing the variable name is a one-line change and the risk is cosmetic.

Pre-merge checks: Passed 2

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between ce6a23f and a838fc8.

Files selected for processing: 1

  • .github/workflows/terraform-github.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread .github/workflows/terraform-github.yml Resolved
Coloured output is making logs hard to read. Disable it everywhere.
@stackhpc-ci

stackhpc-ci commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


Terraform Plan 📖success

Show Plan

undefined

Pusher: @priteau, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub

@priteau priteau closed this Nov 13, 2026
@priteau
priteau deleted the tf-nocolor branch November 13, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants