Fix FIM on Continue. Have specific formatters for chat and FIM #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still testing. Opened a PR to check if I hadn't broken something using CI |
jhrozek
previously approved these changes
Feb 11, 2025
aponcedeleonch
force-pushed
the
format-output-mux-fim
branch
from
92a7698 to
c4c75b5
Compare
Until now we had a general formatter on the way out of muxing. This is wrong since sometimes the pipelines respond with different format for chat or FIM. Such is the case for Ollama. This PR separates the formatters and declares them explicitly so that they're easier to adjust in the future.
aponcedeleonch
force-pushed
the
format-output-mux-fim
branch
from
c4c75b5 to
095bcbb
Compare
JAORMX
previously approved these changes
Feb 12, 2025
JAORMX
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1005
Until now we had a general formatter on the way out of muxing. This is wrong since sometimes the pipelines respond with different format for chat or FIM. Such is the case for Ollama.
This PR separates the formatters and declares them explicitly so that they're easier to adjust in the future.