Fix clippy::needless_borrow throughout stackslib #5651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
jbencin
reviewed
Jan 6, 2025
jbencin
reviewed
Jan 6, 2025
jbencin
reviewed
Jan 6, 2025
jbencin
reviewed
Jan 6, 2025
jbencin
reviewed
Jan 6, 2025
jbencin
reviewed
Jan 6, 2025
jbencin
reviewed
Jan 6, 2025
jbencin
reviewed
Jan 6, 2025
There was a problem hiding this comment.
This is a huge PR for a single lint. I remember one of the first things I noticed about this repo was how many unnecessary refs and &s there were
I made some comments about code this PR touched but you didn't write, I figure it's a good opportunity to clean these things up
obycode
previously approved these changes
Jan 8, 2025
… into fix/clippy-ci-stacks-lib-needless-borrow
Signed-off-by: Jacinta Ferrant <[email protected]>
obycode
previously approved these changes
Jan 9, 2025
jbencin
previously approved these changes
Jan 9, 2025
… into fix/clippy-ci-stacks-lib-needless-borrow
… into fix/clippy-ci-stacks-lib-needless-borrow
obycode
reviewed
Jan 22, 2025
obycode
previously approved these changes
Jan 22, 2025
… into fix/clippy-ci-stacks-lib-needless-borrow
Signed-off-by: Jacinta Ferrant <[email protected]>
obycode
previously approved these changes
Jan 22, 2025
… into fix/clippy-ci-stacks-lib-needless-borrow
obycode
previously approved these changes
Jan 23, 2025
jbencin
previously approved these changes
Jan 23, 2025
… into fix/clippy-ci-stacks-lib-needless-borrow
jbencin
approved these changes
Jan 23, 2025
obycode
approved these changes
Jan 24, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.