Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Refactor block waits #5784

Merged
merged 8 commits into from
Jan 31, 2025
Merged

Test: Refactor block waits #5784

merged 8 commits into from
Jan 31, 2025

Conversation

kantai
Copy link
Member

@kantai kantai commented Jan 31, 2025

Description

Refactor the block waits in the nakamoto_integrations and signer tests. This should reduce a little bit of flakiness across the board.

@kantai kantai requested review from a team as code owners January 31, 2025 15:20
@kantai kantai changed the base branch from master to develop January 31, 2025 15:20
hstove
hstove previously approved these changes Jan 31, 2025
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is a much more readable version, too.

…test retry sleep from 100ms to 500ms (less log spam in tests)
@kantai
Copy link
Member Author

kantai commented Jan 31, 2025

Just look at that glorious green check mark without any re-runs.

@kantai kantai requested review from jbencin and hstove January 31, 2025 20:48
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@kantai kantai enabled auto-merge January 31, 2025 22:10
@kantai kantai added this pull request to the merge queue Jan 31, 2025
Merged via the queue into develop with commit fb6f2b7 Jan 31, 2025
182 checks passed
@kantai kantai deleted the test/refactor-block-waits branch January 31, 2025 22:50
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants