Skip to content

enable clarity-wasm for all epochs #6075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
225 commits
Select commit Hold shift + click to select a range
b13b15d
WIP: add public key to SignerMessages and add signer_state_machine_up…
jferrant Mar 28, 2025
e5d9e40
Merge branch 'feat/send-signer-state-updates' of github.com:jferrant/…
jferrant Mar 31, 2025
c74d0b0
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant Mar 31, 2025
dda2aca
WIP: ugly check for capitulation
jferrant Apr 2, 2025
2337411
WIP: cleanup some stuff
jferrant Apr 2, 2025
1644a3c
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant Apr 3, 2025
443ae92
Fix reorging_signers_capitulate_to_nonreorging_signers_during_tenure_…
jferrant Apr 4, 2025
bb08906
Fix clippy and build errors
jferrant Apr 4, 2025
e97ef7c
feat: add validation, test for signer validation replay blocks
hstove Apr 3, 2025
4736ab4
WIP: Add GlobalStateEvaluator struct
jferrant Apr 4, 2025
a6d993b
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant Apr 4, 2025
cb60dec
WIP: fix insert_update
jferrant Apr 4, 2025
70cb6e7
feat: use JSON payload for tx replay set
hstove Apr 7, 2025
9e10788
Fix entry vs weight check in capitulate_viewpoint
jferrant Apr 7, 2025
8a7f8fe
Increase timeout when waiting for block acceptance from signers
jferrant Apr 7, 2025
6ef6c41
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant Apr 7, 2025
de3f7c1
feat: add `empty_mempool_sleep_ms`
obycode Apr 7, 2025
80c5c6f
test: fix `skip_mining_long_tx`
obycode Apr 7, 2025
7968b49
crc: rename make_stacks_transfer to $1_serialized
hstove Apr 8, 2025
bb7e57b
fix: comment case where block contains non-replay txs
hstove Apr 8, 2025
7143f7b
Merge branch 'develop' into feat/replay-signer-validation
hstove Apr 8, 2025
97a3a50
move restriction to composite action
wileyj Apr 8, 2025
76f6517
Adding attestation and permissions for standalone image
wileyj Apr 8, 2025
e848371
Only build stacks-inspect for test
wileyj Apr 8, 2025
86185f2
fix: method was renamed
hstove Apr 8, 2025
a85d587
feat: avoid unnecessary pause by looping and exiting early
obycode Apr 9, 2025
4fb916d
test: reduce flakiness in `injected_signatures_are_ignored_across_bou…
obycode Apr 9, 2025
04b1c34
CRC: Fix use of weight vs entry in capitulate_miner_view and various …
jferrant Apr 9, 2025
3ea6130
CRC: Fix determination of the active signer protocol version and make…
jferrant Apr 9, 2025
d12fb82
Clippy fixes
jferrant Apr 9, 2025
dbd71ab
modify how environments are used
wileyj Apr 9, 2025
9ef0747
Add a test for determining the latest supported signer protocol version
jferrant Apr 9, 2025
93b2167
Add tests for determine_global_state and determine_global_burn_view
jferrant Apr 9, 2025
1e31382
Add test for capitulate_miner_view
jferrant Apr 9, 2025
0085f73
CRC: remove clones by passing by reference where possible
jferrant Apr 9, 2025
85fdb5a
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant Apr 9, 2025
bc5e170
Merge branch 'develop' into feat/empty_mempool_sleep
obycode Apr 10, 2025
265b10c
add required permissions and environment
wileyj Apr 10, 2025
9f9c160
add missing permissions to binary build step
wileyj Apr 10, 2025
1ebdaaa
Fix test_simple_signer to not attempt to match the received time value
jferrant Apr 10, 2025
9186ffe
CRC: Move signer_state tests to a dedicated test module
jferrant Apr 10, 2025
aab7784
Order the chunks before sending them
jferrant Apr 10, 2025
1058df1
fix: handling of block cost exceeded in validation
hstove Apr 11, 2025
9e7fc89
Merge pull request #5997 from obycode/feat/empty_mempool_sleep
obycode Apr 11, 2025
fe55a46
Add scenario test dev-dependencies
moodmosaic Apr 12, 2025
9290725
Add tests/signer/commands/block_commit.rs
BowTiedRadone Apr 12, 2025
920e8d9
Add tests/signer/commands/block_wait.rs
BowTiedRadone Apr 12, 2025
3866b76
Add tests/signer/commands/boot.rs
BowTiedRadone Apr 12, 2025
a080ceb
Add tests/signer/commands/commit_ops.rs
BowTiedRadone Apr 12, 2025
d075341
Add tests/signer/commands/context.rs
BowTiedRadone Apr 12, 2025
1ffefda
Add tests/signer/commands/mining.rs
BowTiedRadone Apr 12, 2025
2b64f5d
Add tests/signer/commands/mod.rs
BowTiedRadone Apr 12, 2025
14da4dc
Add tests/signer/commands/shutdown.rs
BowTiedRadone Apr 12, 2025
4588a1f
Add tests/signer/commands/stalling.rs
BowTiedRadone Apr 12, 2025
095c40f
Add tests/signer/commands/tenure.rs
BowTiedRadone Apr 12, 2025
49a2f05
Add tests/signer/commands/transfer.rs
BowTiedRadone Apr 12, 2025
1b1d353
Update tests/signer/mod.rs for scenario modules
moodmosaic Apr 12, 2025
50e304a
Merge pull request #6003 from wileyj/chore/update_ci
wileyj Apr 12, 2025
9d4cc3a
Merge pull request #5962 from jferrant/feat/signer-state-conflict-res…
wileyj Apr 13, 2025
e58bfed
update versions.toml for release
wileyj Apr 13, 2025
e8b21fa
Update tests/signer/v0.rs for scenario modules
moodmosaic Apr 12, 2025
7ddadb4
Add allow_reorg_within_first_proposal_burn_block_timing_secs_scenario
moodmosaic Apr 14, 2025
d53e5f5
Merge pull request #6006 from wileyj/chore/3.1.0.0.8_version
wileyj Apr 14, 2025
28cb005
crc: comment improvement
hstove Apr 15, 2025
bca3aa9
feat: reduce default `block_rejection_timeout_steps`
obycode Apr 15, 2025
6b7104a
fix: remove unused stacks-client methods
hstove Apr 15, 2025
7dc5fcb
fix: remove unregistered signers in cleanup_stale_signers
hstove Apr 15, 2025
5d5c91c
fix: clippy errors
hstove Apr 15, 2025
5001523
ci: delete action for Clarity JS SDK
obycode Apr 15, 2025
6046807
Update tests/signer/commands for logging with `info!`
moodmosaic Apr 16, 2025
6979eb1
Update tests/signer/commands/context.rs to derive Clone
moodmosaic Apr 16, 2025
829a96e
feat: include PC abort reason in tx receipt
obycode Apr 16, 2025
6eb7cf0
Rename `MineTenureCommand` to `MineBitcoinBlock` and update `label`
BowTiedRadone Apr 16, 2025
f8d7404
Standardize command naming pattern to not include "Command"
BowTiedRadone Apr 16, 2025
48209a2
Move `MineBitcoinBlock` to commands/mining and remove `tenure` mod
BowTiedRadone Apr 16, 2025
422429f
Run `cargo fmt`
BowTiedRadone Apr 16, 2025
10d4e25
Rename stalling commands to `PauseStacksMining` and `ResumeStacksMining`
BowTiedRadone Apr 16, 2025
081207e
Rename `stalling` mod to `stacks_mining`
BowTiedRadone Apr 16, 2025
922eb75
Rename `mining` mod to `bitcoin_mining`
BowTiedRadone Apr 16, 2025
cc54ebd
refactor: use struct for `AbortedByCallback`
obycode Apr 16, 2025
cdf3ce0
test: fix `repeated_rejection` for new default config
obycode Apr 16, 2025
a27ca5d
Merge pull request #6016 from obycode/chore/remove-clarity-js-sdk-action
wileyj Apr 16, 2025
efa19d4
feat: wait for miner to be unblocked between blocks
obycode Apr 16, 2025
4449e6d
Make sure order doesn't matter when testing simple signer
jferrant Apr 16, 2025
0d35a99
Merge pull request #6011 from stacks-network/release/3.1.0.0.8
wileyj Apr 16, 2025
9427c3d
Fix clippy
jferrant Apr 16, 2025
faed7c4
Merge branch 'develop' into feat/propagate-vm-error
obycode Apr 16, 2025
7817465
Merge branch 'develop' into fix/remove-unused-stacks-client-methods
hstove Apr 17, 2025
31d048c
Merge pull request #6014 from hstove/fix/remove-unused-stacks-client-…
obycode Apr 17, 2025
9dce991
fix: add ClarityError::CostError to special case handling
hstove Apr 17, 2025
2d21872
docs: update documentation about `abort_call_back`
obycode Apr 17, 2025
42b7d62
Update `allow_reorg_within_first_proposal_burn_block_timing_secs_scen…
BowTiedRadone Apr 17, 2025
1c0dc20
Run `cargo fmt-stacks`
BowTiedRadone Apr 17, 2025
e21cd31
fix: comment
hstove Apr 17, 2025
b6f56b7
Merge branch 'develop' into feat/replay-signer-validation
hstove Apr 17, 2025
509b103
fix: error from merge (function renamed)
hstove Apr 17, 2025
a0e3b9b
feat: add state change monitoring for protocol upgrade, #5918
fdefelici Apr 14, 2025
d7b6b01
feat: add prometheus monitoring for signer agreement state conflicts,…
fdefelici Apr 14, 2025
8b9c05e
chore: rename prometheus conflict metric about miner view, #5918
fdefelici Apr 15, 2025
30aaffc
feat: add state change monitoring for miner view update, #5918
fdefelici Apr 17, 2025
66ea1e0
feat: add state change monitoring for miner parent tenure update, #5918
fdefelici Apr 17, 2025
d2b52b3
feat: add signer capitulation latency metric, #5918
fdefelici Apr 18, 2025
740e738
chore: improve state change reason metric description, #5918
fdefelici Apr 18, 2025
4e1e2eb
fix: clippy warnings, #5918
fdefelici Apr 18, 2025
acea311
Merge branch 'develop' into test/scenario
moodmosaic Apr 18, 2025
cf9fc79
fix: do not check for utxos when mock-mining
obycode Apr 18, 2025
d50e407
Merge pull request #6023 from jferrant/chore/fix-test-simple-signer
kantai Apr 18, 2025
535cef0
Merge pull request #6013 from obycode/block_rejection_timeout_steps
wileyj Apr 18, 2025
a7646f9
Merge pull request #6015 from hstove/fix/remove-stale-unregistered-si…
kantai Apr 18, 2025
c89cf7f
docs: update rustdoc
obycode Apr 18, 2025
320e8f0
Merge branch 'develop' into feat/propagate-vm-error
obycode Apr 18, 2025
1e55e15
Create TransactionEventPayload struct and add vm_error to it
jferrant Apr 18, 2025
8d03772
Add a comment to raw_tx to indicate it already has been 0x prefixed
jferrant Apr 18, 2025
03e691c
Reconsider blocks that were rejected with an InvalidParentBlock
jferrant Apr 18, 2025
bdda2cd
add configurable `proposal_wait_time_ms` to signer
kantai Apr 18, 2025
7238d1d
Fix clippy
jferrant Apr 18, 2025
0d7be01
Fix typo in comment
jferrant Apr 18, 2025
01922ea
Update changelog
jferrant Apr 18, 2025
521558f
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant Apr 18, 2025
01ed033
Merge pull request #6026 from obycode/fix/mock-mining
kantai Apr 21, 2025
9a19b37
Add new ValidateRejectCodes that are more descriptive and update fail…
jferrant Apr 21, 2025
96dcd3f
feat: check if a proposals parent has been processed before submit
kantai Apr 21, 2025
e505550
Merge pull request #5994 from hstove/feat/replay-signer-validation
wileyj Apr 22, 2025
c68e1de
chore: update changelog, rename config option
kantai Apr 22, 2025
be8256c
Address suggestions from code review
BowTiedRadone Apr 22, 2025
ac370c0
address PR reviews
kantai Apr 22, 2025
615f8b5
make signer runloop run the "after-event" code on all invocations
kantai Apr 22, 2025
3506c0c
Merge pull request #6030 from kantai/feat/proposal-retries
wileyj Apr 22, 2025
6ed6cfe
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant Apr 22, 2025
aaabb90
Update changelog
jferrant Apr 22, 2025
707c09a
CRC: add unit tests for converting vm_error
jferrant Apr 22, 2025
9f46f6a
test: integrated pinny on stacks-node and added few test tagging samp…
fdefelici Apr 23, 2025
e9be296
Merge pull request #6007 from moodmosaic/test/scenario
wileyj Apr 23, 2025
9a2c7bb
crc: update pinny to v0.0.2 (downgrade toml to v0.5), #6033
fdefelici Apr 24, 2025
5d20db1
chore: resolve merge conflict due to madhouse, #6033
fdefelici Apr 24, 2025
9b26d92
crc: fix pinny commit hash to point to v0.0.2, #6033
fdefelici Apr 24, 2025
5285013
crc: add tagging documentation in contribution page, #6033
fdefelici Apr 24, 2025
3477059
perf: improve next_ready_nakamoto_block
kantai Apr 24, 2025
81ecd36
crc: fix typo in contributing page, #6033
fdefelici Apr 25, 2025
e9f1dd0
feat: add parent_burn_block_hash to /new_burn_block payload
hstove Apr 25, 2025
5979c9d
CRC: typo in unreachable message
jferrant Apr 25, 2025
ff97989
perf: cache pox descendancy check in burnop processing
kantai Apr 25, 2025
9c4a84b
Merge pull request #6035 from kantai/perf/next-ready-block
kantai Apr 25, 2025
f68b5ef
fix: trait impl in test
hstove Apr 25, 2025
8801a39
feat: update event-dispatcher.md docs
hstove Apr 28, 2025
d317474
Merge remote-tracking branch 'origin/develop' into feat/parent-burn-b…
hstove Apr 28, 2025
fb6b385
bump version for signer in versions.toml
wileyj Apr 28, 2025
23c88d3
Merge pull request #6041 from wileyj/chore/signer-3.1.0.0.8.1_version…
wileyj Apr 28, 2025
58cab7d
Merge pull request #6027 from jferrant/fix/reconsider-invalid-parent-…
wileyj Apr 28, 2025
b1545ee
perf: reuse sqlite connection in get() impl for readonly marf instances
kantai Apr 28, 2025
d16bd3a
Merge pull request #6037 from hstove/feat/parent-burn-block-hash-payload
wileyj Apr 29, 2025
3f3dbad
crc: udate contributing description, #6033
fdefelici Apr 29, 2025
f5fac87
crc: update contributing description, #6033
fdefelici Apr 29, 2025
d41b6a8
refactor descendancy cache handling
kantai Apr 29, 2025
3fa17a9
Add StateMachineUpdateContent::V1 which inculdes a vector of replay_t…
jferrant Apr 29, 2025
8a38889
rust fmt
kantai Apr 29, 2025
d8cf1e6
Add suggested clippy fixes
wileyj Apr 29, 2025
bbfc4b0
Merge branch 'develop' into chore/signer-3.1.0.0.8.1_conflicts
wileyj Apr 29, 2025
f5d8417
Fix a few clippy errors and adjust a test function to use the proper …
wileyj Apr 29, 2025
6d3fef8
perf: check and create the md index in the clarity db
kantai Apr 29, 2025
2ff51a2
chore: make test pass on reruns
kantai Apr 29, 2025
cac00cc
Add deserializer for custom blockstack op fields and make sure backwa…
jferrant Apr 30, 2025
c0bde6a
Remove use of macro
jferrant Apr 30, 2025
be740b4
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant Apr 30, 2025
4830d9d
test: defining a first set of tags and apply them on a few tests as a…
fdefelici Apr 30, 2025
820b8b7
chore: update contributing page with test tag set, #6033
fdefelici Apr 30, 2025
d9672e3
fix: ensure peer 0 has a StackerDB
obycode Apr 30, 2025
80f5cca
fix: wait for stackerDB convergence
obycode Apr 30, 2025
8ab3024
chore: fix formatting
obycode Apr 30, 2025
0d0e3b2
Merge branch 'develop' into feat/propagate-vm-error
obycode Apr 30, 2025
5efe165
Merge pull request #6049 from wileyj/chore/signer-3.1.0.0.8.1_conflicts
obycode Apr 30, 2025
cbb4fad
Merge pull request #6044 from kantai/feat/faster-readonly-marf
wileyj Apr 30, 2025
39c5458
Remove testing assert from debugging
jferrant Apr 30, 2025
9541920
Merge branch 'develop' into perf/descendancy-check
kantai Apr 30, 2025
8a55887
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant Apr 30, 2025
3c91a78
Merge pull request #6038 from kantai/perf/descendancy-check
wileyj Apr 30, 2025
436ea91
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant Apr 30, 2025
574e188
Merge pull request #6050 from kantai/feat/check-md-index
wileyj Apr 30, 2025
5f28d6a
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant Apr 30, 2025
87b628e
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant Apr 30, 2025
d6ba211
increase timeout in failing large_mempool_base
jferrant Apr 30, 2025
7bd8d30
Cleanup miner_main_loop so it does not have unnecessary nested loop a…
jferrant Apr 30, 2025
432dcd4
Merge pull request #6034 from fdefelici/test/pinny-stacks-node
wileyj May 1, 2025
67fe44a
CRC: remove unnecessary and_then and just pass up the error in is_par…
jferrant May 1, 2025
032d33e
Fix reorgning signers test and allow caller to specify expected signe…
jferrant May 1, 2025
d4507ee
Merge pull request #6046 from obycode/fix/flaky-net-tests
obycode May 1, 2025
a5b5137
Merge pull request #6060 from jferrant/chore/cleanup-miner-runloop
obycode May 1, 2025
c068de1
Add rollover_signer_protocol_version test to check upgrading and down…
jferrant May 1, 2025
5713197
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant May 1, 2025
dbbdbff
Merge branch 'develop' of https://github.com/stacks-network/stacks-co…
jferrant May 1, 2025
864d098
fix: mock miner should continue mining throughout tenure
obycode May 2, 2025
24f7163
crc: fix record_signer_agreement_capitulation_latency documentation, …
fdefelici May 2, 2025
dc5982c
CRC: cleanup comments, add debug line, and use helper StacksAddress::…
jferrant May 2, 2025
d117a7a
crc: remove system time utility functions, #5918
fdefelici May 2, 2025
4a7b908
Merge pull request #6048 from jferrant/feat/signer-sends-replay-set-i…
obycode May 2, 2025
c9580ae
Add missing import for SUPPORTED_SIGNER_PROTOCOL_VERSION
moodmosaic May 4, 2025
c7e7f34
crc: remove chrono dependency, #5918
fdefelici May 5, 2025
f053755
build all binaries in core build workflow
wileyj May 5, 2025
71b8d49
remove release build arg
wileyj May 5, 2025
0ee0c72
Merge branch 'develop' into chore/add-vm-error-to-transaction-event-p…
wileyj May 5, 2025
c0faf3e
perf: do not read whole snapshot for ancestor check in find_new_block…
kantai Apr 30, 2025
a1e0b25
Merge pull request #6073 from moodmosaic/fix/6072
jferrant May 5, 2025
69b89a1
fix entry block-id/hash cache refactor
kantai May 5, 2025
a46b84c
Merge pull request #6065 from obycode/fix/mock-mining
obycode May 5, 2025
7d7e414
Merge pull request #6025 from jferrant/chore/add-vm-error-to-transact…
obycode May 5, 2025
e0875ed
Merge branch 'develop' into feat/propagate-vm-error
obycode May 5, 2025
e979816
add index for processable_block in staging_blocks
kantai May 5, 2025
b93ca16
move CODEOWNERS and adjust requirements to automatically add multiple…
wileyj May 5, 2025
84511b0
Merge branch 'develop' into fix/6074
obycode May 5, 2025
9b4d899
address PR comments (6081)
wileyj May 5, 2025
9434e29
Merge remote-tracking branch 'origin/develop' into perf/2.0-syncing
kantai May 5, 2025
a7e98cb
fix: cargo check --tests warning
hstove May 5, 2025
3dde4d8
Remove duplicate code when sending block responses
jferrant May 5, 2025
3020f3a
merge: resolve merge conflict, #5918
fdefelici May 6, 2025
16f50a8
Merge pull request #6018 from obycode/feat/propagate-vm-error
hstove May 6, 2025
62202cf
Merge pull request #6083 from hstove/fix/cargo-check-tests-fix
hstove May 6, 2025
38e389f
Merge pull request #6008 from fdefelici/feat/signer-mon-conflicts
jferrant May 6, 2025
1ab867d
Merge pull request #6076 from wileyj/fix/6074
wileyj May 6, 2025
7cd921e
CRC: pass block info as an optonal to send_block_response_impl
jferrant May 6, 2025
1f833be
Fix typo in function def
jferrant May 6, 2025
e10f11c
Merge pull request #6080 from jferrant/chore/cleanup-signers-send-res…
jferrant May 6, 2025
aee48f3
Merge pull request #6079 from kantai/perf/2.0-syncing
wileyj May 6, 2025
e45867c
Merge pull request #6081 from wileyj/chore/codeowners
obycode May 7, 2025
7321f82
feat: enable clarity-wasm for all epochs
csgui May 5, 2025
1045af1
Merge branch 'develop' into feat/clarity-wasm-develop
csgui May 8, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# These owners will be the default owners for everything in
# the repo. Unless a later match takes precedence,
#
# require both blockchain-team-codeowners and blockchain-team to review all PR's not specifically matched below
* @stacks-network/blockchain-team-codeowners @stacks-network/blockchain-team


# Signer code
# require both blockchain-team-codeowners and blockchain-team-signer to review PR's for the signer folder(s)
libsigner/**/*.rs @stacks-network/blockchain-team-codeowners @stacks-network/blockchain-team-signer
stacks-signer/**/*.rs @stacks-network/blockchain-team-codeowners @stacks-network/blockchain-team-signer

# CI workflows
# require both blockchain-team and blockchain-team-ci teams to review PR's modifying CI workflows
/.github/workflows/ @stacks-network/blockchain-team @stacks-network/blockchain-team-ci
/.github/actions/ @stacks-network/blockchain-team @stacks-network/blockchain-team-ci
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ jobs:
needs:
- rustfmt
- check-release
secrets: inherit
uses: ./.github/workflows/github-release.yml
with:
node_tag: ${{ needs.check-release.outputs.node_tag }}
Expand Down
65 changes: 0 additions & 65 deletions .github/workflows/clarity-js-sdk-pr.yml

This file was deleted.

12 changes: 9 additions & 3 deletions .github/workflows/github-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ concurrency:
run-name: ${{ inputs.node_tag || inputs.signer_tag }}

jobs:
## This job's sole purpose is trigger a secondary approval outside of the matrix jobs below.
## This job's sole purpose is trigger a secondary approval outside of the matrix jobs below.
## - If this job isn't approved to run, then the subsequent jobs will also not run - for this reason, we always exit 0
## - `andon-cord` requires the repo environment "Build Release", which will trigger a secondary approval step before running this workflow.
## - `andon-cord` requires the repo environment "Build Release", which will trigger a secondary approval step before running this workflow.
andon-cord:
if: |
inputs.node_tag != '' ||
Expand All @@ -65,6 +65,9 @@ jobs:
runs-on: ubuntu-latest
needs:
- andon-cord
permissions:
id-token: write
attestations: write
strategy:
## Run a maximum of 10 builds concurrently, using the matrix defined in inputs.arch
max-parallel: 10
Expand Down Expand Up @@ -135,6 +138,10 @@ jobs:
inputs.signer_tag != ''
name: Docker Image (Binary)
runs-on: ubuntu-latest
environment: "Push to Docker"
permissions:
id-token: write
attestations: write
needs:
- andon-cord
- build-binaries
Expand Down Expand Up @@ -164,7 +171,6 @@ jobs:
## Create the downstream PR for the release branch to master,develop
create-pr:
if: |
!contains(github.ref, '-rc') &&
(
inputs.node_tag != '' ||
inputs.signer_tag != ''
Expand Down
22 changes: 22 additions & 0 deletions .github/workflows/image-build-source.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ jobs:
runs-on: ubuntu-latest
## Requires the repo environment "Push to Docker", which will trigger a secondary approval step before running this workflow.
environment: "Push to Docker"
permissions:
id-token: write
attestations: write
steps:
## Increase swapfile
- name: Increase swapfile
Expand Down Expand Up @@ -78,3 +81,22 @@ jobs:
GIT_COMMIT=${{ env.GITHUB_SHA_SHORT }}
TARGET_CPU=x86-64-v3
push: ${{ env.DOCKER_PUSH }}

## Generate docker image attestation(s)
- name: Generate artifact attestation (${{ github.event.repository.name }})
id: attest_primary
uses: actions/attest-build-provenance@c074443f1aee8d4aeeae555aebba3282517141b2 # v2.2.3
with:
subject-name: |
index.docker.io/${{env.docker-org}}/${{ github.event.repository.name }}
subject-digest: ${{ steps.docker_build.outputs.digest }}
push-to-registry: true

- name: Generate artifact attestation (stacks-blockchain)
id: attest_secondary
uses: actions/attest-build-provenance@c074443f1aee8d4aeeae555aebba3282517141b2 # v2.2.3
with:
subject-name: |
index.docker.io/${{env.docker-org}}/stacks-blockchain
subject-digest: ${{ steps.docker_build.outputs.digest }}
push-to-registry: true
24 changes: 22 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,25 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to the versioning scheme outlined in the [README.md](README.md).

## [Unreleased]

### Added

- Added field `vm_error` to EventObserver transaction outputs
- Added new `ValidateRejectCode` values to the `/v3/block_proposal` endpoint
- Added `StateMachineUpdateContent::V1` to support a vector of `StacksTransaction` expected to be replayed in subsequent Stacks blocks
- Include a reason string in the transaction receipt when a transaction is rolled back due to a post-condition. This should help users in understanding what went wrong.

### Changed

- Reduce the default `block_rejection_timeout_steps` configuration so that miners will retry faster when blocks fail to reach 70% approved or 30% rejected.
- Added index for `next_ready_nakamoto_block()` which improves block processing performance.
- Added a new field, `parent_burn_block_hash`, to the payload that is included in the `/new_burn_block` event observer payload.

### Fixed

- Fix regression in mock-mining, allowing the mock miner to continue mining blocks throughout a tenure instead of failing after mining the tenure change block.

## [3.1.0.0.8]

### Added
Expand All @@ -19,8 +38,9 @@ and this project adheres to the versioning scheme outlined in the [README.md](RE

- When a miner times out waiting for signatures, it will re-propose the same block instead of building a new block ([#5877](https://github.com/stacks-network/stacks-core/pull/5877))
- Improve tenure downloader trace verbosity applying proper logging level depending on the tenure state ("debug" if unconfirmed, "info" otherwise) ([#5871](https://github.com/stacks-network/stacks-core/issues/5871))
- Remove warning log about missing UTXOs when a node is configured as `miner` with `mock_mining` mode enabled ([#5841](https://github.com/stacks-network/stacks-core/issues/5841))
- Deprecated the `wait_on_interim_blocks` option in the miner config file. This option is no longer needed, as the miner will always wait for interim blocks to be processed before mining a new block. To wait extra time in between blocks, use the `min_time_between_blocks_ms` option instead.
- Remove warning log about missing UTXOs when a node is configured as `miner` with `mock_mining` mode enabled ([#5841](https://github.com/stacks-network/stacks-core/issues/5841))
- Deprecated the `wait_on_interim_blocks` option in the miner config file. This option is no longer needed, as the miner will always wait for interim blocks to be processed before mining a new block. To wait extra time in between blocks, use the `min_time_between_blocks_ms` option instead. ([#5979](https://github.com/stacks-network/stacks-core/pull/5979))
- Added `empty_mempool_sleep_ms` to the miner config file to control the time to wait in between mining attempts when the mempool is empty. If not set, the default sleep time is 2.5s. ([#5997](https://github.com/stacks-network/stacks-core/pull/5997))

## [3.1.0.0.7]

Expand Down
3 changes: 0 additions & 3 deletions CODEOWNERS

This file was deleted.

22 changes: 18 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -361,17 +361,31 @@ A non-exhaustive list of examples of consensus-critical changes include:

- Every consensus-critical change needs an integration test to verify that the feature activates only when the hard fork activates.

PRs must include test coverage. However, if your PR includes large tests or tests which cannot run in parallel
- PRs must include test coverage. However, if your PR includes large tests or tests which cannot run in parallel
(which is the default operation of the `cargo test` command), these tests should be decorated with `#[ignore]`.

A test should be marked `#[ignore]` if:

1. It does not _always_ pass `cargo test` in a vanilla environment
1. It does not _always_ pass `cargo test` in a vanilla environment
(i.e., it does not need to run with `--test-threads 1`).

2. Or, it runs for over a minute via a normal `cargo test` execution
2. Or, it runs for over a minute via a normal `cargo test` execution
(the `cargo test` command will warn if this is not the case).

- **Integration tests need to be properly tagged** using [pinny-rs](https://github.com/BitcoinL2-Labs/pinny-rs/) crate. Tagging requires two fundamental steps:
1. Define allowed tags in the package `Cargo.toml` file (if needed).
2. Apply relevant tags to the tests, picking from the allowed set.

Then it will be possible to run tests with filtering based on the tags using `cargo test` and `cargo nextest` runner.
> For more information and examples on how tagging works, refer to the [pinny-rs](https://github.com/BitcoinL2-Labs/pinny-rs/) readme.

Below the tag set currently defined with related purpose:

| Tag | Description |
|-----------------|----------------------------------------------|
| `slow` | tests running over a minute |
| `bitcoind` | tests requiring bitcoin daemon |
| `flaky` | tests that exhibit flaky behavior |

## Formatting

PRs will be checked against `rustfmt` and will _fail_ if not properly formatted.
Expand Down
47 changes: 47 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading