-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resources docsify pages #48
Conversation
There is a little more that I could do to clean up the notes, but the main goal of this PR was to get all of the links working again, and to provide basic navigation so that if I click from the main readme into a folder, then I have a clear path back without having to use the back button. There were also some basic things, like adding titles and some copy updates to try and make things more evergreen and consistent. @lrettig note that the relative links should be working in this format now based on the setting we updated in the last PR, there was one that we missed and I was able to test, so I followed that format to keep everything as simple as possible. |
Oh, and another major update was in two docsify settings:
This tells docsify to not try and render the file per the documentation here, and should resolve the 404s for those as well.
This tells docsify to automatically scroll to the top when loading a new link, which can be overridden by using a specific If all of this looks good I can do a similar sweep across the stacksgov/pm repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran docsify locally, clicked around, everything looked good except the relative links in the survey folder README - for some reason, docsify gets confused by relative links in subfolders. I made these into absolute links and everything now LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look. Do you need any help @whoabuddy
Based on observations clicking around the new docsify site and those listed in stacksgov/pm#90.