Add PacketList Datatypes #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow data structures to share mbufs by introducing a reference counter (DPDK primitives). This could have been done with an Rc in Rust stdlib; that would be more idiomatic but would come with more overhead. It also would have introduced challenges with cross-core data sharing.
Add PacketList DataTypes
|
Will go ahead and merge soon, but would be nice to have someone else take a look at this to see if it makes sense at some point (especially the mbuf refcounting) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create multiple, user-defined datatypes for caching Mbufs (raw packets) for end of connection delivery.
This also adds infrastructure for sharing Mbufs using DPDK's reference counting infrastructure (see memory/mbuf file). This gives us a way to share Mbufs between multiple data structures (e.g., pre- and post-reassembly) without copying and with lower overhead than Rust's Rc or Arc infrastructure. It may encounter issues if Mbufs are shared across threads, but they will not be in the current architecture. This infrastructure is critical for supporting future streaming datatypes.
Note that, with some of these datatypes, mempool availability can become the bottleneck, especially when working with UDP connections (which cannot be delivered until timeout). In some cases, it is more efficient to copy Mbufs into byte arrays.
Testing done: wrote examples for offline mode; printed out raw bytes (hex) in packet lists and compared to wireshark raw bytes.