Minor TCP Reassembly and Packet Tracking Changes #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thearossman
commented
Dec 2, 2024
thearossman
commented
- Performance: clear OOO buffers when reassembly is no longer needed
- Performance: drop tracked Mbufs more greedily
- Update termination heuristic - must see both FINs and both ACKs for FINs
- Some minor cleanup
We shouldn't consider a TCP connection complete until both sides have acknowledged the other's FIN. This introduces slight overhead (tracking acknowledgement numbers), but is needed for some packet analysis (e.g., TCP flags) use cases.
May provide modest mempool utilization improvement for certain connection-tracking applications on lossy networks.
- Distinguish between `update` (metadata) and `track_packets` (presumed to be less common and more expensive). Also distinguish between `cache_packets` (storing raw mbufs in case of filter match on packet-level subscription) and `track_packets` (tracking for duration of connection). tl;dr - try to only use mbufs if needed and release them quickly. - Remove `update_reassembled` and `track_packets_reassembled`. The expensive operation is reassembly itself, not potentially invoking no-op functions. Replace with a single `reassemble` action.
stream reassembly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.