Finetune fix #7629
Merged
Finetune fix #7629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i would highly appreciate a quick merge. |
okhat
reviewed
Feb 19, 2025
| # TODO(nit) Pass an identifier to the job so that we can tell the logs | ||
| # coming from different fine-tune threads. | ||
|
|
||
| key_to_job = {} | ||
| for key, finetune_kwargs in finetune_dict.items(): | ||
| lm = finetune_kwargs.pop("lm") | ||
| # TODO: The following line is a hack. We shoul re-think how to free |
okhat
reviewed
Feb 19, 2025
| return program(**kwargs), dspy.settings.trace.copy() | ||
|
|
||
| _, outputs = evaluator(wrapped_program, metric=wrapped_metric) | ||
| _metric = metric if metric else lambda example, prediction: 1 |
There was a problem hiding this comment.
Why is this part removing the code from wrapped_program? It's there for a good reason. It avoid looping and calling the program twice.
okhat
reviewed
Feb 19, 2025
| @@ -35,7 +35,7 @@ | |||
| }, | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": 1, | |||
| "execution_count": null, | |||
There was a problem hiding this comment.
There are a lot of changes to this file but I'm not sure if they're actually intentional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.