Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify genDst.C to allow use of FXT DB flavors #730

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

genevb
Copy link
Contributor

@genevb genevb commented Jan 28, 2025

Very simple change.

@genevb
Copy link
Contributor Author

genevb commented Feb 13, 2025

@fgeurts and @plexoos :

It would be helpful to have this merged ASAP, and then tag SL24c (SL24c_0) which is identical to SL24b except for the addition of this single changed macro.

We can consider freezing an SL25a at some point soon with the GMT and FWD tracking changes, but I want to complete the recently started conversion production effort with what is essentially SL24b plus this macro change.

@plexoos
Copy link
Member

plexoos commented Feb 13, 2025

I see what you’re asking for… but do you think it would make sense to just patch the SL24b branch with this commit and tag it as SL24b_1?

@genevb
Copy link
Contributor Author

genevb commented Feb 13, 2025

I see what you’re asking for… but do you think it would make sense to just patch the SL24b branch with this commit and tag it as SL24b_1?

The reason against this is that I used this macro for the P24y.SL24b conversion production that did not get btofFXT correct. I will need to reproduce that data, and for bookkeeping, it's best if we just make that P24y.SL24c.

@plexoos
Copy link
Member

plexoos commented Feb 13, 2025

Okay, fine. In the case of the SL24b branch, I see that it didn’t really branch from the main branch (still at SL24b_0), and for this reason, SL24c would also branch directly from the main branch. I guess my concern is that, in general, we should avoid creating official branches off anything other than the main branch to prevent confusion with tags.

@plexoos plexoos merged commit 6138c21 into star-bnl:main Feb 13, 2025
4 checks passed
@genevb
Copy link
Contributor Author

genevb commented Feb 13, 2025

I'm fine with it not being an SL24c branch, just an SL24c tag....is that good?

plexoos pushed a commit that referenced this pull request Feb 13, 2025
@plexoos
Copy link
Member

plexoos commented Feb 13, 2025

Creating a tag without a branch is possible but will likely be just as confusing as, for example, having an SL24c_0 tag on the SL24b branch :) could be puzzling for someone trying to figure this out in the future.

Anyway, in this particular case, I don’t see any issue with creating both SL24c and SL24c_0, which has now been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants