-
Notifications
You must be signed in to change notification settings - Fork 796
Typed data enum fixes (SNIP-12) #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
* fix: missing snip-12 enum type dependency * test: add nested enum tests --------- Co-authored-by: Petar Penovic <[email protected]>
The expected hash is based on a patched version of starknet.js at: starknet-io/starknet.js#1292
The expected hash is based on a patched version of starknet.js at: starknet-io/starknet.js#1292
* test: add snip-12 simple enum test case The expected hash is based on a patched version of starknet.js at: starknet-io/starknet.js#1292 * feat: port starknet.js SNIP-12 deviations
Just released it as the v6.24.1 pre-release. it will be promoted as a main release before the v7 beta with RPC 0.8 support is promoted to a pre-release, so should be relatively soon. |
@penovicp Should convert this to a draft while we agree on the new revision? |
Motivation and Resolution
Aggregate for the typed data enum fixes. Extracted so potential impact can be coordinated and so that less impactful prereleases can proceed unhindered.
Aggregated PRs:
:
in enum encoding #1288Corresponding issues: