Skip to content

Typed data enum fixes (SNIP-12) #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Typed data enum fixes (SNIP-12) #1292

wants to merge 3 commits into from

Conversation

penovicp
Copy link
Collaborator

@penovicp penovicp commented Jan 7, 2025

@xJonathanLEI
Copy link
Contributor

Hi @penovicp can we have confirmation on whether #1289 would be released? There seems to be consensus that this particular patch is the most harmless out of the three (in terms of breakage), but there doesn't seem to be any activity here.

xJonathanLEI added a commit to xJonathanLEI/starknet-rs that referenced this pull request Mar 20, 2025
The expected hash is based on a patched version of starknet.js at:

    starknet-io/starknet.js#1292
xJonathanLEI added a commit to xJonathanLEI/starknet-rs that referenced this pull request Mar 20, 2025
The expected hash is based on a patched version of starknet.js at:

    starknet-io/starknet.js#1292
xJonathanLEI added a commit to xJonathanLEI/starknet-rs that referenced this pull request Mar 20, 2025
* test: add snip-12 simple enum test case

The expected hash is based on a patched version of starknet.js at:

    starknet-io/starknet.js#1292

* feat: port starknet.js SNIP-12 deviations
@penovicp
Copy link
Collaborator Author

Hi @penovicp can we have confirmation on whether #1289 would be released? There seems to be consensus that this particular patch is the most harmless out of the three (in terms of breakage), but there doesn't seem to be any activity here.

Just released it as the v6.24.1 pre-release. it will be promoted as a main release before the v7 beta with RPC 0.8 support is promoted to a pre-release, so should be relatively soon.

@tabaktoni
Copy link
Member

@penovicp Should convert this to a draft while we agree on the new revision?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants