CairoByteArray #1469
CairoByteArray #1469
Conversation
src/utils/encode.ts
Outdated
| } | ||
|
|
||
| // Otherwise treat as UTF-8 text | ||
| return utf8ToArray(str); |
There was a problem hiding this comment.
As utf8ToArray is now deprecated, utf8ToUint8Array should be used.
src/utils/cairoDataTypes/uint32.ts
Outdated
| return this.data; | ||
| } | ||
|
|
||
| toUnicode() { |
There was a problem hiding this comment.
I have a doubt about the name of this method.
As it's working only if the number is the result of a utf-8 encoding, I propose something like .decodeUtf8 or .decodeFromUtf8
src/utils/cairoDataTypes/felt.ts
Outdated
| return uint8ArrayToBigInt(this.data); | ||
| } | ||
|
|
||
| toUnicode() { |
There was a problem hiding this comment.
Same comment as uint32.
src/utils/cairoDataTypes/bytes31.ts
Outdated
| return uint8ArrayToBigInt(this.data); | ||
| } | ||
|
|
||
| toUnicode() { |
src/utils/cairoDataTypes/bytes31.ts
Outdated
| /** | ||
| * from String | ||
| */ | ||
| constructor(data: string); |
There was a problem hiding this comment.
Shouldn't we be able to create a Bytes31 by aBigNumberish?
| /** | ||
| * byteArray from String | ||
| */ | ||
| public constructor(data: String); |
There was a problem hiding this comment.
Same comments than bytes31.
| ...this.pending_word_len.toApiRequest(), | ||
| ]; | ||
| } | ||
| } |
There was a problem hiding this comment.
Compare to other Cairo types, are missing . toBigInt, .toHexString, .is, .isAbiType and something to decode from utf-8.
.is seems unnecessary, but the others have a sense to be there too.
Motivation and Resolution
Fix: #1455
RPC version (if applicable)
Usage related changes
TODO
Development related changes
TODO
Checklist: